tea/browsertrix
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[Chore] Webpack: Migrate from onBeforeSetupMiddleware to setupMiddlewares (#2080)

Browse Source 
Resolves the big red
`[DEP_WEBPACK_DEV_SERVER_ON_BEFORE_SETUP_MIDDLEWARE] DeprecationWarning:
'onBeforeSetupMiddleware' option is deprecated. Please use the
'setupMiddlewares' option.` warnings when starting Webpack.

---------

Co-authored-by: Ilya Kreymer <ikreymer@gmail.com>
This commit is contained in:
Emma Segal-Grossman 2024-10-02 22:35:32 -04:00 committed by GitHub
parent adec41bd70
commit 87cc38b737
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
frontend/scripts/serve.js
View File

@ -16,7 +16,7 @@ const app = express();
const { devServer } = devConfig; const { devServer } = devConfig;
devServer.onBeforeSetupMiddleware({ app }); devServer.setupMiddlewares([], { app });
app.use("/", express.static("dist")); app.use("/", express.static("dist"));
Object.keys(devServer.proxy).forEach((path) => { Object.keys(devServer.proxy).forEach((path) => {

5
frontend/webpack.dev.js
View File

@ -58,8 +58,8 @@ module.exports = [
}, },
}, },
}, },
// Serve replay service worker file setupMiddlewares: (middlewares, server) => {
onBeforeSetupMiddleware: (server) => { // Serve replay service worker file
server.app?.get("/replay/sw.js", (req, res) => { server.app?.get("/replay/sw.js", (req, res) => {
res.set("Content-Type", "application/javascript"); res.set("Content-Type", "application/javascript");
res.send(`importScripts("${RWP_BASE_URL}sw.js")`); res.send(`importScripts("${RWP_BASE_URL}sw.js")`);
@ -75,6 +75,7 @@ module.exports = [
res.set("Content-Type", "application/javascript"); res.set("Content-Type", "application/javascript");
res.status(404).send(`{"error": "placeholder_for_replay"}`); res.status(404).send(`{"error": "placeholder_for_replay"}`);
}); });
return middlewares;
}, },
port: 9870, port: 9870,
}, },