From 87cc38b73790a78193ea1b73da0e56cddf5a708e Mon Sep 17 00:00:00 2001 From: Emma Segal-Grossman Date: Wed, 2 Oct 2024 22:35:32 -0400 Subject: [PATCH] [Chore] Webpack: Migrate from `onBeforeSetupMiddleware` to `setupMiddlewares` (#2080) Resolves the big red `[DEP_WEBPACK_DEV_SERVER_ON_BEFORE_SETUP_MIDDLEWARE] DeprecationWarning: 'onBeforeSetupMiddleware' option is deprecated. Please use the 'setupMiddlewares' option.` warnings when starting Webpack. --------- Co-authored-by: Ilya Kreymer --- frontend/scripts/serve.js | 2 +- frontend/webpack.dev.js | 5 +++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/frontend/scripts/serve.js b/frontend/scripts/serve.js index 2a7330a3..7163efa3 100644 --- a/frontend/scripts/serve.js +++ b/frontend/scripts/serve.js @@ -16,7 +16,7 @@ const app = express(); const { devServer } = devConfig; -devServer.onBeforeSetupMiddleware({ app }); +devServer.setupMiddlewares([], { app }); app.use("/", express.static("dist")); Object.keys(devServer.proxy).forEach((path) => { diff --git a/frontend/webpack.dev.js b/frontend/webpack.dev.js index 261ef864..191c1ca9 100644 --- a/frontend/webpack.dev.js +++ b/frontend/webpack.dev.js @@ -58,8 +58,8 @@ module.exports = [ }, }, }, - // Serve replay service worker file - onBeforeSetupMiddleware: (server) => { + setupMiddlewares: (middlewares, server) => { + // Serve replay service worker file server.app?.get("/replay/sw.js", (req, res) => { res.set("Content-Type", "application/javascript"); res.send(`importScripts("${RWP_BASE_URL}sw.js")`); @@ -75,6 +75,7 @@ module.exports = [ res.set("Content-Type", "application/javascript"); res.status(404).send(`{"error": "placeholder_for_replay"}`); }); + return middlewares; }, port: 9870, },