683e531cc0
Partially addresses https://github.com/webrecorder/browsertrix/issues/2171 - [x] Reimplement `pretty-ms`'s rounding logic to convert to a `Intl.DurationFormat`-compatible object - [x] Add `localize.duration` and `localize.humanizeDuration` methods - [x] Replace `pretty-ms` usage with localized formatting - [x] Add `Intl.DurationFormat` polyfill - [x] Update localize tests - [x] Fix broken tests (thank you @SuaYoo!) - This looks to be possibly a bug somewhere in the web test runner's code? Have yet to figure this one out - Might be related to these: https://github.com/web-dev-server/web-dev-server/issues/1 https://github.com/guybedford/es-module-lexer/issues/82 — both closed with no comments or resolution 🙃 — `es-module-lexer` seems to be most likely, given it's a native module & might be handling unicode sequences incorrectly or not at all? - [x] Clean up messy `index.d.ts` — probably split this out? The definitions haven't yet made their way into `esnext` https://github.com/microsoft/TypeScript/issues/60608 --------- Co-authored-by: emma-sg <emma-sg@users.noreply.github.com> Co-authored-by: sua yoo <sua@suayoo.com>
52 lines
1.4 KiB
YAML
52 lines
1.4 KiB
YAML
name: Playwright Tests
|
|
|
|
on:
|
|
pull_request:
|
|
paths:
|
|
- 'frontend/src/**'
|
|
- 'frontend/*.json'
|
|
- 'frontend/*.js'
|
|
- 'frontend/*.ts'
|
|
|
|
jobs:
|
|
test:
|
|
timeout-minutes: 60
|
|
runs-on: ubuntu-latest
|
|
env:
|
|
DEV_PASSWORD: ${{ secrets.DEV_PASSWORD }}
|
|
API_BASE_URL: ${{ secrets.API_BASE_URL }}
|
|
working-directory: ./frontend
|
|
steps:
|
|
- name: Checkout
|
|
uses: actions/checkout@v4
|
|
- name: Setup Node
|
|
uses: actions/setup-node@v4
|
|
with:
|
|
node-version: '20'
|
|
cache: 'yarn'
|
|
cache-dependency-path: frontend/yarn.lock
|
|
- name: Install dependencies
|
|
working-directory: frontend
|
|
run: yarn install --frozen-lockfile
|
|
- name: Install Playwright Browsers
|
|
run: yarn add playwright@1.49.0 && yarn playwright install --with-deps
|
|
working-directory: ./frontend
|
|
- name: Create env file
|
|
run: |
|
|
cd frontend
|
|
touch .env
|
|
echo DEV_PASSWORD="${{ secrets.DEV_PASSWORD }}" >> .env
|
|
echo API_BASE_URL=${{ secrets.API_BASE_URL }} >> .env
|
|
cat .env
|
|
- name: Build frontend
|
|
run: cd frontend && yarn build
|
|
id: build-frontend
|
|
- name: Run Playwright tests
|
|
run: cd frontend && yarn playwright test
|
|
- uses: actions/upload-artifact@v4
|
|
if: always()
|
|
with:
|
|
name: playwright-report
|
|
path: frontend/playwright-report/
|
|
retention-days: 30
|