browsertrix/backend/btrixcloud/file_uploads.py
Tessa Walsh d3e241ad03
Validate seed files on backend and add tests (#2781)
Fixes #2780 

This PR adds additional backend validation for seed file uploads to fail
a seed upload if no valid seeds are found. It adds two new test cases to
ensure seed uploads will fail for binary files and for text files that
do not contain any valid URLs.
2025-07-31 23:20:58 -07:00

451 lines
14 KiB
Python

"""user-uploaded files"""
from typing import TYPE_CHECKING, Union, Any, Optional, Dict, Tuple, List
from datetime import timedelta
import os
import tempfile
from uuid import UUID, uuid4
import aiohttp
from fastapi import APIRouter, Depends, HTTPException, Request
import pymongo
from .models import (
SeedFileOut,
SeedFile,
UserFile,
UserFilePreparer,
Organization,
User,
AddedResponseId,
SuccessResponse,
MIN_UPLOAD_PART_SIZE,
PaginatedUserFileResponse,
)
from .pagination import DEFAULT_PAGE_SIZE, paginated_format
from .utils import dt_now, is_url
from .storages import StorageOps, CHUNK_SIZE
if TYPE_CHECKING:
from .orgs import OrgOps
else:
OrgOps = object
ALLOWED_UPLOAD_TYPES = ["seedFile"]
SEED_FILE_MAX_SIZE = 25_000_000
SEED_FILE_ALLOWED_EXTENSIONS = [".txt"]
# ============================================================================
# pylint: disable=too-many-instance-attributes
class FileUploadOps:
"""user non-wacz file upload management"""
org_ops: OrgOps
storage_ops: StorageOps
# pylint: disable=too-many-locals, too-many-arguments, invalid-name
def __init__(self, mdb, org_ops, storage_ops):
self.files = mdb["file_uploads"]
self.crawl_configs = mdb["crawl_configs"]
self.org_ops = org_ops
self.storage_ops = storage_ops
self.router = APIRouter(
prefix="/files",
tags=["userfiles"],
responses={404: {"description": "Not found"}},
)
async def init_index(self):
"""init index for user file uploads db collection"""
await self.files.create_index([("oid", pymongo.HASHED)])
async def get_file_raw(
self,
file_id: UUID,
org: Optional[Organization] = None,
type_: Optional[str] = None,
) -> Dict[str, Any]:
"""Get raw file from db"""
query: dict[str, object] = {"_id": file_id}
if org:
query["oid"] = org.id
if type_:
query["type"] = type_
res = await self.files.find_one(query)
if not res:
raise HTTPException(status_code=404, detail="file_not_found")
return res
async def get_seed_file(
self,
file_id: UUID,
org: Optional[Organization] = None,
type_: Optional[str] = None,
) -> SeedFile:
"""Get file by UUID"""
file_raw = await self.get_file_raw(file_id, org, type_)
return SeedFile.from_dict(file_raw)
async def get_seed_file_out(
self,
file_id: UUID,
org: Optional[Organization] = None,
type_: Optional[str] = None,
headers: Optional[dict] = None,
) -> SeedFileOut:
"""Get file output model by UUID"""
user_file = await self.get_seed_file(file_id, org, type_)
return await user_file.get_file_out(org, self.storage_ops, headers)
async def list_seed_files(
self,
org: Organization,
page_size: int = DEFAULT_PAGE_SIZE,
page: int = 1,
sort_by: str = "created",
sort_direction: int = -1,
headers: Optional[dict] = None,
) -> Tuple[list[SeedFileOut], int]:
"""list all user-uploaded files"""
# pylint: disable=too-many-locals
# Zero-index page for query
page = page - 1
skip = page_size * page
match_query = {"oid": org.id}
aggregate: List[Dict[str, Any]] = [{"$match": match_query}]
if sort_by:
if sort_by not in (
"created",
"size",
"mime",
"userName",
"type",
"firstSeed",
"seedCount",
):
raise HTTPException(status_code=400, detail="invalid_sort_by")
if sort_direction not in (1, -1):
raise HTTPException(status_code=400, detail="invalid_sort_direction")
aggregate.extend([{"$sort": {sort_by: sort_direction}}])
aggregate.extend(
[
{
"$facet": {
"items": [
{"$skip": skip},
{"$limit": page_size},
],
"total": [{"$count": "count"}],
}
},
]
)
cursor = self.files.aggregate(aggregate)
results = await cursor.to_list(length=1)
result = results[0]
items = result["items"]
try:
total = int(result["total"][0]["count"])
except (IndexError, ValueError):
total = 0
user_files = []
for res in items:
file_ = SeedFile.from_dict(res)
file_out = await file_.get_file_out(org, self.storage_ops, headers)
user_files.append(file_out)
return user_files, total
# pylint: disable=duplicate-code
async def upload_user_file_stream(
self,
stream,
filename: str,
org: Organization,
user: User,
upload_type: str = "seedFile",
) -> Dict[str, Union[bool, UUID]]:
"""Upload file stream and return its id"""
self.org_ops.can_write_data(org, include_time=False)
_, extension = os.path.splitext(filename)
# Validate extension
allowed_extensions = SEED_FILE_ALLOWED_EXTENSIONS
if extension not in allowed_extensions:
raise HTTPException(status_code=400, detail="invalid_extension")
file_id = uuid4()
new_filename = f"{upload_type}-{str(file_id)}{extension}"
prefix = org.storage.get_storage_extra_path(str(org.id)) + f"{upload_type}s/"
file_prep = UserFilePreparer(
prefix,
new_filename,
original_filename=filename,
user=user,
created=dt_now(),
)
async def stream_iter():
"""iterate over each chunk and compute and digest + total size"""
async for chunk in stream:
file_prep.add_chunk(chunk)
yield chunk
print(f"{upload_type} stream upload starting", flush=True)
if not await self.storage_ops.do_upload_multipart(
org,
file_prep.upload_name,
stream_iter(),
MIN_UPLOAD_PART_SIZE,
mime=file_prep.mime,
):
print(f"{upload_type} stream upload failed", flush=True)
raise HTTPException(status_code=400, detail="upload_failed")
print(f"{upload_type} stream upload complete", flush=True)
file_obj = file_prep.get_user_file(org.storage)
# Validate size
max_size = SEED_FILE_MAX_SIZE
if file_obj.size > max_size:
print(
f"{upload_type} stream upload failed: max size (25 MB) exceeded",
flush=True,
)
await self.storage_ops.delete_file_object(org, file_obj)
raise HTTPException(
status_code=400,
detail="max_size_25_mb_exceeded",
)
first_seed, seed_count = await self._parse_seed_info_from_file(file_obj, org)
if not first_seed or seed_count == 0:
print(
f"{upload_type} stream upload failed: invalid seed file",
flush=True,
)
await self.storage_ops.delete_file_object(org, file_obj)
raise HTTPException(status_code=400, detail="invalid_seed_file")
# Save file to database
file_to_insert = SeedFile(
id=file_id,
oid=org.id,
filename=file_obj.filename,
hash=file_obj.hash,
size=file_obj.size,
storage=file_obj.storage,
originalFilename=file_obj.originalFilename,
mime=file_obj.mime,
userid=file_obj.userid,
userName=file_obj.userName,
created=file_obj.created,
firstSeed=first_seed,
seedCount=seed_count,
)
await self.files.insert_one(file_to_insert.to_dict())
await self.org_ops.inc_org_bytes_stored_field(
org.id, "bytesStoredSeedFiles", file_obj.size
)
return {"added": True, "id": file_id}
async def _parse_seed_info_from_file(
self, file_obj: UserFile, org: Organization
) -> Tuple[str, int]:
first_seed = ""
seed_count = 0
file_url = await file_obj.get_absolute_presigned_url(
org, self.storage_ops, None
)
with tempfile.TemporaryFile() as fp:
async with aiohttp.ClientSession() as session:
async with session.get(file_url) as resp:
async for chunk in resp.content.iter_chunked(CHUNK_SIZE):
fp.write(chunk)
fp.seek(0)
for line in fp:
if not line:
continue
try:
seed_url = line.decode("utf-8").strip()
if not first_seed and is_url(seed_url):
first_seed = seed_url
seed_count += 1
# pylint: disable=broad-exception-caught
except Exception:
pass
return first_seed, seed_count
async def delete_seed_file(
self, file_id: UUID, org: Organization
) -> Dict[str, bool]:
"""Delete user-uploaded file from storage and db"""
file = await self.get_seed_file(file_id, org)
# Make sure seed file isn't currently referenced by any workflows
if file.type == "seedFile":
matching_workflow = await self.crawl_configs.find_one(
{"config.seedFileId": file_id}
)
if matching_workflow:
raise HTTPException(status_code=400, detail="seed_file_in_use")
await self.storage_ops.delete_file_object(org, file)
await self.files.delete_one({"_id": file_id, "oid": org.id})
if file.type == "seedFile":
await self.org_ops.inc_org_bytes_stored_field(
org.id, "bytesStoredSeedFiles", -file.size
)
return {"success": True}
async def calculate_seed_file_storage(self, oid: UUID) -> int:
"""Calculate total storage of seed files in org"""
total_size = 0
cursor = self.files.find({"oid": oid, "type": "seedFile"})
async for file_dict in cursor:
total_size += file_dict.get("size", 0)
return total_size
async def cleanup_unused_seed_files(self):
"""Delete older seed files that are not used in workflows"""
cleanup_after_mins = int(os.environ.get("CLEANUP_FILES_AFTER_MINUTES", 1440))
print(
f"Cleaning up unused seed files more than {cleanup_after_mins} minutes old",
flush=True,
)
cleanup_before = dt_now() - timedelta(minutes=cleanup_after_mins)
match_query = {"type": "seedFile", "created": {"$lt": cleanup_before}}
errored = False
error_msg = ""
async for file_dict in self.files.find(match_query):
file_id = file_dict["_id"]
first_matching_workflow = await self.crawl_configs.find_one(
{"config.seedFileId": file_id}
)
if first_matching_workflow:
continue
try:
org = await self.org_ops.get_org_by_id(file_dict["oid"])
await self.delete_seed_file(file_id, org)
print(f"Deleted unused seed file {file_id}", flush=True)
# pylint: disable=broad-exception-caught
except Exception as err:
print(f"Error deleting unused seed file {file_id}: {err}", flush=True)
# Raise exception later so that job fails but only after attempting
# to clean up all files first
errored = True
error_msg = str(err)
if errored:
raise RuntimeError(f"Error deleting unused seed files: {error_msg}")
# ============================================================================
def init_file_uploads_api(
mdb,
org_ops,
storage_ops,
user_dep,
):
"""Init /files api routes"""
ops = FileUploadOps(mdb, org_ops, storage_ops)
router = ops.router
org_crawl_dep = org_ops.org_crawl_dep
org_viewer_dep = org_ops.org_viewer_dep
@router.put("/seedFile", response_model=AddedResponseId)
async def upload_seedfile_stream(
request: Request,
filename: str,
org: Organization = Depends(org_crawl_dep),
user: User = Depends(user_dep),
):
return await ops.upload_user_file_stream(
request.stream(), filename, org, user, upload_type="seedFile"
)
# pylint: disable=too-many-arguments
@router.get("", response_model=PaginatedUserFileResponse)
async def list_seed_files(
request: Request,
org: Organization = Depends(org_viewer_dep),
pageSize: int = DEFAULT_PAGE_SIZE,
page: int = 1,
sortBy: str = "created",
sortDirection: int = -1,
):
# pylint: disable=duplicate-code
user_files, total = await ops.list_seed_files(
org,
page_size=pageSize,
page=page,
sort_by=sortBy,
sort_direction=sortDirection,
headers=dict(request.headers),
)
return paginated_format(user_files, total, page, pageSize)
@router.get("/{file_id}", response_model=SeedFileOut)
async def get_seed_file(
file_id: UUID, request: Request, org: Organization = Depends(org_viewer_dep)
):
return await ops.get_seed_file_out(file_id, org, headers=dict(request.headers))
@router.delete("/{file_id}", response_model=SuccessResponse)
async def delete_user_file(
file_id: UUID, org: Organization = Depends(org_crawl_dep)
):
return await ops.delete_seed_file(file_id, org)
if org_ops.router:
org_ops.router.include_router(router)
return ops