browsertrix/backend/btrixcloud/storages.py
Ilya Kreymer 41c054d209
Storage ops followup type checking (#1274)
* storage ops: follow up to #1257:
- fix refactor typo
- add type hints for all storageops apis (add mypy_boto3_s3 and types_aiobotocore_s3 for type hints)
2023-10-11 14:03:00 -07:00

569 lines
18 KiB
Python

"""
Storage API
"""
from typing import Optional, Union, Iterator, Iterable, List, Dict, AsyncIterator
from urllib.parse import urlsplit
from contextlib import asynccontextmanager
import asyncio
import heapq
import json
import itertools
import os
from datetime import datetime
from fastapi import Depends, HTTPException
from stream_zip import stream_zip, NO_COMPRESSION_64
import aiobotocore.session
import boto3
from mypy_boto3_s3.client import S3Client
from mypy_boto3_s3.type_defs import CompletedPartTypeDef
from types_aiobotocore_s3 import S3Client as AIOS3Client
from .models import (
CrawlFile,
CrawlFileOut,
Organization,
DefaultStorage,
S3Storage,
User,
)
from .zip import (
sync_get_zip_file,
sync_get_log_stream,
)
from .utils import is_bool
CHUNK_SIZE = 1024 * 256
# ============================================================================
class StorageOps:
"""All storage handling, download/upload operations"""
def __init__(self, org_ops, crawl_manager):
self.storages = {}
self.org_ops = org_ops
self.crawl_manager = crawl_manager
self.is_local_minio = is_bool(os.environ.get("IS_LOCAL_MINIO"))
with open("/tmp/storages/storages.json", encoding="utf-8") as fh:
storage_list = json.loads(fh.read())
for storage in storage_list:
name = storage.get("name")
type_ = storage.get("type", "s3")
if type_ == "s3":
self.storages[name] = self._create_s3_storage(storage)
else:
# expand when additional storage options are supported
raise TypeError("Only s3 storage supported for now")
def _create_s3_storage(self, storage: dict[str, str]) -> S3Storage:
"""create S3Storage object"""
endpoint_url = storage["endpoint_url"]
bucket_name = storage.get("bucket_name")
if bucket_name:
endpoint_url += bucket_name + "/"
if self.is_local_minio:
access_endpoint_url = "/data/"
use_access_for_presign = False
else:
access_endpoint_url = storage.get("access_endpoint_url") or endpoint_url
use_access_for_presign = True
return S3Storage(
access_key=storage["access_key"],
secret_key=storage["secret_key"],
region=storage.get("region", ""),
endpoint_url=endpoint_url,
access_endpoint_url=access_endpoint_url,
use_access_for_presign=use_access_for_presign,
)
def has_storage(self, name) -> bool:
"""assert the specified storage exists"""
return name in self.storages
async def update_storage(
self, storage: Union[S3Storage, DefaultStorage], org: Organization, user: User
) -> dict[str, bool]:
"""update storage for org"""
if storage.type == "default":
if not self.has_storage(storage.name):
raise HTTPException(
status_code=400, detail=f"Invalid default storage {storage.name}"
)
else:
try:
await self.verify_storage_upload(storage, ".btrix-upload-verify")
# pylint: disable=raise-missing-from
except:
raise HTTPException(
status_code=400,
detail="Could not verify custom storage. Check credentials are valid?",
)
await self.org_ops.update_storage(org, storage)
await self.crawl_manager.update_org_storage(org.id, str(user.id), org.storage)
return {"updated": True}
@asynccontextmanager
async def get_s3_client(
self, storage: S3Storage, use_access=False
) -> AsyncIterator[tuple[AIOS3Client, str, str]]:
"""context manager for s3 client"""
endpoint_url = (
storage.endpoint_url if not use_access else storage.access_endpoint_url
)
if not endpoint_url.endswith("/"):
endpoint_url += "/"
parts = urlsplit(endpoint_url)
bucket, key = parts.path[1:].split("/", 1)
endpoint_url = parts.scheme + "://" + parts.netloc
session = aiobotocore.session.get_session()
async with session.create_client(
"s3",
region_name=storage.region,
endpoint_url=endpoint_url,
aws_access_key_id=storage.access_key,
aws_secret_access_key=storage.secret_key,
) as client:
yield client, bucket, key
def get_sync_s3_client(
self, storage: S3Storage, use_access=False
) -> tuple[S3Client, str, str, str]:
"""context manager for s3 client"""
endpoint_url = storage.endpoint_url
if not endpoint_url.endswith("/"):
endpoint_url += "/"
parts = urlsplit(endpoint_url)
bucket, key = parts.path[1:].split("/", 1)
endpoint_url = parts.scheme + "://" + parts.netloc
client = boto3.client(
"s3",
region_name=storage.region,
endpoint_url=endpoint_url,
aws_access_key_id=storage.access_key,
aws_secret_access_key=storage.secret_key,
)
public_endpoint_url = (
storage.endpoint_url if not use_access else storage.access_endpoint_url
)
return client, bucket, key, public_endpoint_url
async def verify_storage_upload(self, storage: S3Storage, filename: str) -> None:
"""Test credentials and storage endpoint by uploading an empty test file"""
async with self.get_s3_client(storage) as (client, bucket, key):
key += filename
data = b""
resp = await client.put_object(Bucket=bucket, Key=key, Body=data)
assert resp["ResponseMetadata"]["HTTPStatusCode"] == 200
def get_org_storage(
self, org: Organization, storage_name="default", check_name_first=False
) -> S3Storage:
"""get storage for org, either looking for default storage name first
or custom storage from the org. Check default storage first if flag
set to true"""
if check_name_first and storage_name:
s3storage = self.storages.get(storage_name)
elif org.storage.type == "s3":
s3storage = org.storage
else:
s3storage = self.storages.get(storage_name)
if not s3storage:
raise TypeError("No Default Storage Found, Invalid Storage Type")
return s3storage
async def do_upload_single(
self, org: Organization, filename: str, data, storage_name="default"
) -> None:
"""do upload to specified key"""
s3storage = self.get_org_storage(org, storage_name)
async with self.get_s3_client(s3storage) as (client, bucket, key):
key += filename
await client.put_object(Bucket=bucket, Key=key, Body=data)
def get_sync_client(
self, org: Organization, storage_name="default", use_access=False
) -> tuple[S3Client, str, str, str]:
"""get sync client"""
s3storage = self.get_org_storage(org, storage_name)
return self.get_sync_s3_client(s3storage, use_access=use_access)
# pylint: disable=too-many-arguments,too-many-locals
async def do_upload_multipart(
self,
org: Organization,
filename: str,
file_: AsyncIterator,
min_size: int,
storage_name="default",
) -> bool:
"""do upload to specified key using multipart chunking"""
s3storage = self.get_org_storage(org, storage_name)
async def get_next_chunk(file_, min_size) -> bytes:
total = 0
bufs = []
async for chunk in file_:
bufs.append(chunk)
total += len(chunk)
if total >= min_size:
break
if len(bufs) == 1:
return bufs[0]
return b"".join(bufs)
async with self.get_s3_client(s3storage) as (client, bucket, key):
key += filename
mup_resp = await client.create_multipart_upload(
ACL="bucket-owner-full-control", Bucket=bucket, Key=key
)
upload_id = mup_resp["UploadId"]
parts = []
part_number = 1
try:
while True:
chunk = await get_next_chunk(file_, min_size)
resp = await client.upload_part(
Bucket=bucket,
Body=chunk,
UploadId=upload_id,
PartNumber=part_number,
Key=key,
)
print(
f"part added: {part_number} {len(chunk)} {upload_id}",
flush=True,
)
part: CompletedPartTypeDef = {
"PartNumber": part_number,
"ETag": resp["ETag"],
}
parts.append(part)
part_number += 1
if len(chunk) < min_size:
break
await client.complete_multipart_upload(
Bucket=bucket,
Key=key,
UploadId=upload_id,
MultipartUpload={"Parts": parts},
)
print(f"Multipart upload succeeded: {upload_id}")
return True
# pylint: disable=broad-exception-caught
except Exception as exc:
await client.abort_multipart_upload(
Bucket=bucket, Key=key, UploadId=upload_id
)
print(exc)
print(f"Multipart upload failed: {upload_id}")
return False
async def get_presigned_url(
self, org: Organization, crawlfile: CrawlFile, duration=3600
) -> str:
"""generate pre-signed url for crawl file"""
s3storage = self.get_org_storage(org, crawlfile.def_storage_name, True)
async with self.get_s3_client(s3storage, s3storage.use_access_for_presign) as (
client,
bucket,
key,
):
key += crawlfile.filename
presigned_url = await client.generate_presigned_url(
"get_object", Params={"Bucket": bucket, "Key": key}, ExpiresIn=duration
)
if (
not s3storage.use_access_for_presign
and s3storage.access_endpoint_url
and s3storage.access_endpoint_url != s3storage.endpoint_url
):
presigned_url = presigned_url.replace(
s3storage.endpoint_url, s3storage.access_endpoint_url
)
return presigned_url
async def delete_crawl_file_object(
self, org: Organization, crawlfile: CrawlFile
) -> bool:
"""delete crawl file from storage."""
return await self.delete_file(
org, crawlfile.filename, crawlfile.def_storage_name
)
async def delete_file(
self, org: Organization, filename: str, def_storage_name="default"
) -> bool:
"""delete specified file from storage"""
status_code = None
s3storage = self.get_org_storage(org, def_storage_name, True)
async with self.get_s3_client(s3storage, s3storage.use_access_for_presign) as (
client,
bucket,
key,
):
key += filename
response = await client.delete_object(Bucket=bucket, Key=key)
status_code = response["ResponseMetadata"]["HTTPStatusCode"]
return status_code == 204
async def sync_stream_wacz_logs(
self,
org: Organization,
wacz_files: List[CrawlFile],
log_levels: List[str],
contexts: List[str],
) -> Iterator[bytes]:
"""Return filtered stream of logs from specified WACZs sorted by timestamp"""
client, bucket, key, _ = self.get_sync_client(org)
loop = asyncio.get_event_loop()
resp = await loop.run_in_executor(
None,
self._sync_get_logs,
wacz_files,
log_levels,
contexts,
client,
bucket,
key,
)
return resp
def _sync_get_logs(
self,
wacz_files: List[CrawlFile],
log_levels: List[str],
contexts: List[str],
client,
bucket: str,
key: str,
) -> Iterator[bytes]:
"""Generate filtered stream of logs from specified WACZs sorted by timestamp"""
# pylint: disable=too-many-function-args
def stream_log_lines(
wacz_key, wacz_filename, cd_start, log_zipinfo
) -> Iterator[dict]:
"""Pass lines as json objects"""
print(
f"Fetching log {log_zipinfo.filename} from {wacz_filename}", flush=True
)
line_iter: Iterator[bytes] = sync_get_log_stream(
client, bucket, wacz_key, log_zipinfo, cd_start
)
for line in line_iter:
yield _parse_json(line.decode("utf-8", errors="ignore"))
def stream_json_lines(
iterator: Iterable[dict], log_levels: List[str], contexts: List[str]
) -> Iterator[bytes]:
"""Yield parsed JSON dicts as JSON-lines bytes after filtering as necessary"""
for line_dict in iterator:
if log_levels and line_dict["logLevel"] not in log_levels:
continue
if contexts and line_dict["context"] not in contexts:
continue
json_str = json.dumps(line_dict, ensure_ascii=False) + "\n"
yield json_str.encode("utf-8")
def organize_based_on_instance_number(
wacz_files: List[CrawlFile],
) -> List[List[CrawlFile]]:
"""Place wacz_files into their own list based on instance number"""
wacz_files.sort(key=lambda file: file.filename)
waczs_groups: Dict[str, List[CrawlFile]] = {}
for file in wacz_files:
instance_number = file.filename[
file.filename.rfind("-") + 1 : file.filename.rfind(".")
]
if instance_number in waczs_groups:
waczs_groups[instance_number].append(file)
else:
waczs_groups[instance_number] = [file]
return list(waczs_groups.values())
log_generators: List[Iterator[dict]] = []
waczs_groups = organize_based_on_instance_number(wacz_files)
for instance_list in waczs_groups:
wacz_log_streams: List[Iterator[dict]] = []
for wacz_file in instance_list:
wacz_key = key + wacz_file.filename
cd_start, zip_file = sync_get_zip_file(client, bucket, wacz_key)
log_files = [
f
for f in zip_file.filelist
if f.filename.startswith("logs/") and not f.is_dir()
]
log_files.sort(key=lambda log_zipinfo: log_zipinfo.filename)
for log_zipinfo in log_files:
wacz_log_streams.append(
stream_log_lines(
wacz_key, wacz_file.filename, cd_start, log_zipinfo
)
)
log_generators.append(itertools.chain(*wacz_log_streams))
heap_iter = heapq.merge(*log_generators, key=lambda entry: entry["timestamp"])
return stream_json_lines(heap_iter, log_levels, contexts)
def _sync_dl(
self, all_files: List[CrawlFileOut], client: S3Client, bucket: str, key: str
) -> Iterator[bytes]:
"""generate streaming zip as sync"""
for file_ in all_files:
file_.path = file_.name
datapackage = {
"profile": "multi-wacz-package",
"resources": [file_.dict() for file_ in all_files],
}
datapackage_str = json.dumps(datapackage).encode("utf-8")
def get_file(name) -> Iterator[bytes]:
response = client.get_object(Bucket=bucket, Key=key + name)
return response["Body"].iter_chunks(chunk_size=CHUNK_SIZE)
def member_files():
modified_at = datetime(year=1980, month=1, day=1)
perms = 0o664
for file_ in all_files:
yield (
file_.name,
modified_at,
perms,
NO_COMPRESSION_64,
get_file(file_.name),
)
yield (
"datapackage.json",
modified_at,
perms,
NO_COMPRESSION_64,
(datapackage_str,),
)
return stream_zip(member_files(), chunk_size=CHUNK_SIZE)
async def download_streaming_wacz(
self, org: Organization, files: List[CrawlFileOut]
) -> Iterator[bytes]:
"""return an iter for downloading a stream nested wacz file
from list of files"""
client, bucket, key, _ = self.get_sync_client(org)
loop = asyncio.get_event_loop()
resp = await loop.run_in_executor(
None, self._sync_dl, files, client, bucket, key
)
return resp
# ============================================================================
def _parse_json(line) -> dict:
"""Parse JSON str into dict."""
parsed_json: Optional[dict] = None
try:
parsed_json = json.loads(line)
except json.JSONDecodeError as err:
print(f"Error decoding json-l line: {line}. Error: {err}", flush=True)
return parsed_json or {}
# ============================================================================
def init_storages_api(org_ops, crawl_manager, user_dep):
"""API for updating storage for an org"""
storage_ops = StorageOps(org_ops, crawl_manager)
if not org_ops.router:
return storage_ops
router = org_ops.router
org_owner_dep = org_ops.org_owner_dep
# pylint: disable=bare-except, raise-missing-from
@router.patch("/storage", tags=["organizations"])
async def update_storage(
storage: Union[S3Storage, DefaultStorage],
org: Organization = Depends(org_owner_dep),
user: User = Depends(user_dep),
):
return await storage_ops.update_storage(storage, org, user)
return storage_ops