tea/browsertrix
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
6a94c64fa2
browsertrix/frontend/src
History
Emma Segal-Grossman 6a94c64fa2
ensure loader fills image swiper, and only display loader when replay data is nullish, not when it's loaded but there's no image data (#1819) 
Closes #1818 

- Refactors image renderers, and changes the condition for which the
loading indicator is displayed from "`<data>.blobUrl` exists and has a
truthey value" to "`<data>` is not nullish"
- Adds an additional class config to the shared QA loading indicator,
and uses it in the image slider view to add a background and aspect
ratio to the loading indicator's container so that it takes up the space
it should and has an opaque background

| Before | After |
| --- | --- |
| <img width="813" alt="Screenshot 2024-05-22 at 5 17 14 PM"
src="https://github.com/webrecorder/browsertrix/assets/5727389/fb8a3a83-a0c8-46c1-b59b-a59adff2a175">
| <img width="813" alt="Screenshot 2024-05-22 at 5 17 31 PM"
src="https://github.com/webrecorder/browsertrix/assets/5727389/6fe5d04a-ffa9-4fc3-bc3b-bdb9b7b30948">
|
2024-05-28 14:02:49 -04:00
..
__generated__ Add Repository Index + Chart Rename + Docs Rename (#1708) 2024-04-21 09:42:25 -07:00
__mocks__ Fix asset imports in tests (#1611) 2024-03-19 13:06:07 -07:00
assets Frontend: App Branding! (#1592) 2024-04-17 23:40:02 -04:00
classes Add ESLint rules for import ordering (#1608) 2024-03-18 21:50:02 -04:00
components Misc UI fixes (primarily buttons) (#1814) 2024-05-22 15:55:52 -04:00
controllers Fix browser navigation button usage in QA review (#1776) 2024-05-07 19:42:43 -07:00
features UX improvements to browser profile editing & creating view (#1815) 2024-05-27 16:57:33 -07:00
pages ensure loader fills image swiper, and only display loader when replay data is nullish, not when it's loaded but there's no image data (#1819) 2024-05-28 14:02:49 -04:00
types UX improvements to browser profile editing & creating view (#1815) 2024-05-27 16:57:33 -07:00
utils Fix truncation for long workflow / item names (#1773) 2024-05-03 13:48:18 -04:00
index.ejs QA review Replay embed improvements (#1775) 2024-05-10 11:30:21 +02:00
index.test.ts Add ESLint rules for import ordering (#1608) 2024-03-18 21:50:02 -04:00
index.ts Misc UI fixes (primarily buttons) (#1814) 2024-05-22 15:55:52 -04:00
manifest.webmanifest Adds favicons! (#1584) 2024-03-16 15:11:31 -07:00
replayWebPage.d.ts Auto-load seed url when replaying seeded crawls (#1786) 2024-05-07 14:03:14 -04:00
routes.ts Add new WIP QA Review page (#1500) 2024-02-20 00:26:38 -08:00
shoelace.ts Add QA columns to archived item list (#1683) 2024-04-22 13:19:07 -07:00
styles.css
theme.stylesheet.css QA review Replay embed improvements (#1775) 2024-05-10 11:30:21 +02:00
theme.ts ESLint improvements & Typescript upgrade (#1501) 2024-01-31 14:42:06 -05:00