Partially addresses https://github.com/webrecorder/browsertrix/issues/2171 - [x] Reimplement `pretty-ms`'s rounding logic to convert to a `Intl.DurationFormat`-compatible object - [x] Add `localize.duration` and `localize.humanizeDuration` methods - [x] Replace `pretty-ms` usage with localized formatting - [x] Add `Intl.DurationFormat` polyfill - [x] Update localize tests - [x] Fix broken tests (thank you @SuaYoo!) - This looks to be possibly a bug somewhere in the web test runner's code? Have yet to figure this one out - Might be related to these: https://github.com/web-dev-server/web-dev-server/issues/1 https://github.com/guybedford/es-module-lexer/issues/82 — both closed with no comments or resolution 🙃 — `es-module-lexer` seems to be most likely, given it's a native module & might be handling unicode sequences incorrectly or not at all? - [x] Clean up messy `index.d.ts` — probably split this out? The definitions haven't yet made their way into `esnext` https://github.com/microsoft/TypeScript/issues/60608 --------- Co-authored-by: emma-sg <emma-sg@users.noreply.github.com> Co-authored-by: sua yoo <sua@suayoo.com>
86 lines
2.4 KiB
YAML
86 lines
2.4 KiB
YAML
name: Frontend Prepare Build
|
|
on:
|
|
pull_request:
|
|
paths:
|
|
- 'frontend/src/**'
|
|
- 'frontend/*.json'
|
|
- 'frontend/*.js'
|
|
- 'frontend/*.ts'
|
|
- '.github/workflows/frontend-build-check.yaml'
|
|
jobs:
|
|
setup-and-build:
|
|
runs-on: ubuntu-latest
|
|
permissions:
|
|
# Give the default GITHUB_TOKEN write permission to commit and push the
|
|
# added or changed files to the repository.
|
|
contents: write
|
|
|
|
steps:
|
|
# Setup:
|
|
- name: Checkout
|
|
uses: actions/checkout@v4
|
|
with:
|
|
ref: ${{ github.head_ref }}
|
|
- name: Setup Node
|
|
uses: actions/setup-node@v4
|
|
with:
|
|
node-version: '18'
|
|
cache: 'yarn'
|
|
cache-dependency-path: frontend/yarn.lock
|
|
- name: Restore cache
|
|
uses: actions/cache@v4
|
|
with:
|
|
path: frontend/dist
|
|
key: ${{ runner.os }}-btrix-frontend-build-${{ hashFiles('frontend/dist') }}
|
|
restore-keys: |
|
|
${{ runner.os }}-btrix-frontend-build-
|
|
- name: Install dependencies
|
|
working-directory: frontend
|
|
env:
|
|
HUSKY: 0
|
|
run: yarn install --frozen-lockfile
|
|
- name: Install Playwright Browsers
|
|
working-directory: frontend
|
|
env:
|
|
HUSKY: 0
|
|
run: yarn playwright install --with-deps
|
|
|
|
# Lint:
|
|
- name: Lint
|
|
working-directory: frontend
|
|
run: yarn lint:check
|
|
|
|
# Localize:
|
|
- name: Extract strings
|
|
working-directory: frontend
|
|
run: yarn localize:extract
|
|
- name: Commit extracted strings
|
|
uses: stefanzweifel/git-auto-commit-action@v5
|
|
with:
|
|
commit_message: Apply `localize:extract` changes
|
|
file_pattern: '**/*.xlf'
|
|
skip_fetch: true
|
|
skip_checkout: true
|
|
- name: Check localization build
|
|
working-directory: frontend
|
|
run: yarn localize:build
|
|
|
|
# Test:
|
|
- name: Unit tests
|
|
working-directory: frontend
|
|
run: yarn test
|
|
|
|
# Check build:
|
|
- name: Set up Docker Buildx
|
|
uses: docker/setup-buildx-action@v2
|
|
with:
|
|
driver-opts: network=host
|
|
- name: Build Frontend
|
|
uses: docker/build-push-action@v3
|
|
with:
|
|
context: frontend
|
|
load: true
|
|
tags: webrecorder/browsertrix-frontend:latest
|
|
cache-from: type=gha,scope=frontend
|
|
cache-to: type=gha,scope=frontend,mode=max
|