From f788934ef5b3c681fab8989894fad08311c6a5ba Mon Sep 17 00:00:00 2001 From: Henry Wilkinson Date: Wed, 24 May 2023 12:30:31 -0400 Subject: [PATCH] Fix copy tags button disabling when no tags on Crawl Details page (#877) --- frontend/src/pages/org/crawl-detail.ts | 4 ++-- frontend/src/pages/org/crawls-list.ts | 2 +- frontend/src/pages/org/workflow-detail.ts | 2 +- frontend/src/pages/org/workflows-list.ts | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/frontend/src/pages/org/crawl-detail.ts b/frontend/src/pages/org/crawl-detail.ts index a834855a..22b1bffb 100644 --- a/frontend/src/pages/org/crawl-detail.ts +++ b/frontend/src/pages/org/crawl-detail.ts @@ -455,8 +455,8 @@ export class CrawlDetail extends LiteElement { - CopyButton.copyToClipboard(this.crawl!.tags.join(","))} - ?disabled=${this.crawl.tags.length} + CopyButton.copyToClipboard(this.crawl!.tags.join(", "))} + ?disabled=${!this.crawl.tags.length} > ${msg("Copy Tags")} diff --git a/frontend/src/pages/org/crawls-list.ts b/frontend/src/pages/org/crawls-list.ts index 4fb6bab4..91936c08 100644 --- a/frontend/src/pages/org/crawls-list.ts +++ b/frontend/src/pages/org/crawls-list.ts @@ -545,7 +545,7 @@ export class CrawlsList extends LiteElement { ${msg("Copy Crawl ID")} CopyButton.copyToClipboard(crawl.tags.join(","))} + @click=${() => CopyButton.copyToClipboard(crawl.tags.join(", "))} ?disabled=${!crawl.tags.length} > diff --git a/frontend/src/pages/org/workflow-detail.ts b/frontend/src/pages/org/workflow-detail.ts index 991372f9..aa98b327 100644 --- a/frontend/src/pages/org/workflow-detail.ts +++ b/frontend/src/pages/org/workflow-detail.ts @@ -650,7 +650,7 @@ export class WorkflowDetail extends LiteElement { ${msg("Edit Workflow Settings")} CopyButton.copyToClipboard(workflow.tags.join(","))} + @click=${() => CopyButton.copyToClipboard(workflow.tags.join(", "))} ?disabled=${!workflow.tags.length} > diff --git a/frontend/src/pages/org/workflows-list.ts b/frontend/src/pages/org/workflows-list.ts index fb6e1071..3b458921 100644 --- a/frontend/src/pages/org/workflows-list.ts +++ b/frontend/src/pages/org/workflows-list.ts @@ -428,7 +428,7 @@ export class WorkflowsList extends LiteElement { ${msg("Edit Workflow Settings")} CopyButton.copyToClipboard(workflow.tags.join(","))} + @click=${() => CopyButton.copyToClipboard(workflow.tags.join(", "))} ?disabled=${!workflow.tags.length} >