From f5c120b529f2f990cbc0319f3e60961a137013f4 Mon Sep 17 00:00:00 2001
From: Ilya Kreymer <ikreymer@users.noreply.github.com>
Date: Tue, 3 Jun 2025 16:28:34 +0000
Subject: [PATCH] Don't clobber existing helm chart in release! (#2643)

Switch to different github release action:
- avoids clobbering existing release if already published, updates
existing draft only with latest Helm chart
- also sets name to `Browsertrix <version>`, fills in changelist.
- fixes #2642

Tested:
- New draft release created (since branch ends in `-release`)
- Running multiple types to ensure chart is updated in draft
- Switching to older release to ensure chart is *NOT* clobbered
---
 .github/workflows/publish-helm-chart.yaml | 17 ++++++++++-------
 1 file changed, 10 insertions(+), 7 deletions(-)

diff --git a/.github/workflows/publish-helm-chart.yaml b/.github/workflows/publish-helm-chart.yaml
index acd16db5..19591090 100644
--- a/.github/workflows/publish-helm-chart.yaml
+++ b/.github/workflows/publish-helm-chart.yaml
@@ -1,4 +1,4 @@
-name: Publish Helm Chart
+name: Make Draft + Upload Helm Chart
 
 on:
   push:
@@ -30,7 +30,7 @@ jobs:
           echo "version=$(cat version.txt)" >> "$GITHUB_ENV"
 
       - name: Upload Chart To GitHub
-        uses: softprops/action-gh-release@v1
+        uses: ncipollo/release-action@v1
         with:
           body: |
             ## Deployment
@@ -50,9 +50,12 @@ jobs:
 
             See [the development guide](https://docs.browsertrix.com/deploy/) for more info how to deploy Browsertrix.
 
-          files: |
-            .chart-out/browsertrix-v${{ env.version }}.tgz
-            .chart-out/btrix-proxies-0.1.0.tgz
-          tag_name: v${{ env.version }}
+          allowUpdates: true
+          artifactErrorsFailBuild: true
+          artifacts: .chart-out/browsertrix-v${{ env.version }}.tgz,.chart-out/btrix-proxies-0.1.0.tgz
           draft: true
-          fail_on_unmatched_files: true
+          generateReleaseNotes: true
+          name: Browsertrix v${{ env.version }}
+          skipIfReleaseExists: true
+          tag: v${{ env.version }}
+          updateOnlyUnreleased: true