tea/browsertrix
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix workflow language setting showing HTML code in select element (#1702)

Browse Source 
Closes #1655

### Changes

Removes the separate element inside the `<sl-select>` and instead
doesn't show localized language unless it's different from the language
in the current locale
This commit is contained in:
Emma Segal-Grossman 2024-04-19 11:39:04 -04:00 committed by GitHub
parent 80008a2853
commit ecaa851688
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 2 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
frontend/src/components/ui/language-select.ts
View File

@ -1,7 +1,7 @@
import { localized, msg } from "@lit/localize"; import { localized, msg } from "@lit/localize";
import type { SlSelect } from "@shoelace-style/shoelace"; import type { SlSelect } from "@shoelace-style/shoelace";
import ISO6391, { type LanguageCode } from "iso-639-1"; import ISO6391, { type LanguageCode } from "iso-639-1";
import { css, html, LitElement } from "lit"; import { css, html, LitElement, nothing } from "lit";
import { customElement, property } from "lit/decorators.js"; import { customElement, property } from "lit/decorators.js";
import { ifDefined } from "lit/directives/if-defined.js"; import { ifDefined } from "lit/directives/if-defined.js";
import sortBy from "lodash/fp/sortBy"; import sortBy from "lodash/fp/sortBy";
@ -35,10 +35,6 @@ export class LanguageSelect extends LitElement {
sl-select::part(control) { sl-select::part(control) {
box-shadow: var(--sl-shadow-small); box-shadow: var(--sl-shadow-small);
} }
sl-menu-item:not(:hover) .secondaryText {
color: var(--sl-color-neutral-400);
}
`; `;
@property({ type: String }) @property({ type: String })
@ -69,7 +65,7 @@ export class LanguageSelect extends LitElement {
${languages.map( ${languages.map(
({ code, name, nativeName }) => html` ({ code, name, nativeName }) => html`
<sl-option value=${code}> <sl-option value=${code}>
${name} <span class="secondaryText">(${nativeName})</span> ${name} ${name !== nativeName ? `(${nativeName})` : nothing}
</sl-option> </sl-option>
`, `,
)} )}