tea/browsertrix
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix QA run deletion (#1721)

Browse Source 
Fixes unable to delete QA run from the QA tab "Analysis Runs" list.
This commit is contained in:
sua yoo 2024-04-22 13:15:42 -07:00 committed by GitHub
parent 1844e761dc
commit db6091b09c
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 16 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
frontend/src/pages/org/archived-item-detail/archived-item-detail.ts
View File

@ -272,6 +272,7 @@ export class ArchivedItemDetail extends TailwindElement {
.qaRuns=${this.qaRuns} .qaRuns=${this.qaRuns}
.qaRunId=${this.qaRunId} .qaRunId=${this.qaRunId}
.mostRecentNonFailedQARun=${this.mostRecentNonFailedQARun} .mostRecentNonFailedQARun=${this.mostRecentNonFailedQARun}
@btrix-qa-runs-update=${() => void this.fetchQARuns()}
></btrix-archived-item-detail-qa> ></btrix-archived-item-detail-qa>
`, `,
); );

16
frontend/src/pages/org/archived-item-detail/ui/qa.ts
View File

@ -105,6 +105,9 @@ function statusWithIcon(
`; `;
} }
/**
* @fires btrix-qa-runs-update
*/
@localized() @localized()
@customElement("btrix-archived-item-detail-qa") @customElement("btrix-archived-item-detail-qa")
export class ArchivedItemDetailQA extends TailwindElement { export class ArchivedItemDetailQA extends TailwindElement {
@ -376,6 +379,16 @@ export class ArchivedItemDetailQA extends TailwindElement {
} }
private readonly renderQARunRows = (qaRuns: QARun[]) => { private readonly renderQARunRows = (qaRuns: QARun[]) => {
if (!qaRuns.length) {
return html`
<div
class="col-span-4 flex h-full flex-col items-center justify-center gap-2 p-3 text-xs text-neutral-500"
>
<sl-icon name="slash-circle"></sl-icon>
${msg("No analysis runs found")}
</div>
`;
}
return qaRuns.map( return qaRuns.map(
(run, idx) => html` (run, idx) => html`
<btrix-table-row class=${idx > 0 ? "border-t" : ""}> <btrix-table-row class=${idx > 0 ? "border-t" : ""}>
@ -511,6 +524,7 @@ export class ArchivedItemDetailQA extends TailwindElement {
variant="danger" variant="danger"
@click=${async () => { @click=${async () => {
await this.deleteQARun(runToBeDeleted.id); await this.deleteQARun(runToBeDeleted.id);
this.dispatchEvent(new CustomEvent("btrix-qa-runs-update"));
this.deleting = null; this.deleting = null;
void this.deleteQADialog?.hide(); void this.deleteQADialog?.hide();
}} }}
@ -768,7 +782,7 @@ export class ArchivedItemDetailQA extends TailwindElement {
async deleteQARun(id: string) { async deleteQARun(id: string) {
try { try {
await this.api.fetch( await this.api.fetch(
`/orgs/${this.orgId}/crawls/${this.crawlId}`, `/orgs/${this.orgId}/crawls/${this.crawlId}/qa/delete`,
this.authState!, this.authState!,
{ method: "POST", body: JSON.stringify({ qa_run_ids: [id] }) }, { method: "POST", body: JSON.stringify({ qa_run_ids: [id] }) },
); );