From cabf4ccc218fac192564051022233d95fb8a7c64 Mon Sep 17 00:00:00 2001 From: Vinzenz Sinapius Date: Thu, 28 Sep 2023 21:10:20 +0200 Subject: [PATCH] Disable `smtp_use_tls` with `false` instead of empty string (#1184) `smtp_use_tls = bool(os.environ.get("EMAIL_SMTP_USE_TLS", True))` would only disable tls when `EMAIL_SMTP_USE_TLS` is set to an empty string which is not intuitive --- backend/btrixcloud/emailsender.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/backend/btrixcloud/emailsender.py b/backend/btrixcloud/emailsender.py index f860b3d2..ac1640ba 100644 --- a/backend/btrixcloud/emailsender.py +++ b/backend/btrixcloud/emailsender.py @@ -17,7 +17,9 @@ class EmailSender: self.reply_to = os.environ.get("EMAIL_REPLY_TO") or self.sender self.smtp_server = os.environ.get("EMAIL_SMTP_HOST") self.smtp_port = int(os.environ.get("EMAIL_SMTP_PORT", 587)) - self.smtp_use_tls = bool(os.environ.get("EMAIL_SMTP_USE_TLS", True)) + self.smtp_use_tls = ( + os.environ.get("EMAIL_SMTP_USE_TLS", "true").lower() != "false" + ) self.default_origin = os.environ.get("APP_ORIGIN")