tea/browsertrix
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Frontend QA dual slider view doesn't correctly show missing images (#1770)

Browse Source 
Also fixes overflow (641309f) & pluralization (1b24abd) issues
This commit is contained in:
Emma Segal-Grossman 2024-04-30 19:33:32 -04:00 committed by GitHub
parent e022994f4e
commit c5b69f814d
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
frontend/src/pages/org/archived-item-detail/ui/qa.ts
View File

@ -188,7 +188,7 @@ export class ArchivedItemDetailQA extends TailwindElement {
this.mostRecentNonFailedQARun.stats.found === 0 this.mostRecentNonFailedQARun.stats.found === 0
? msg("Loading") ? msg("Loading")
: `${this.mostRecentNonFailedQARun.stats.done}/${this.mostRecentNonFailedQARun.stats.found}` : `${this.mostRecentNonFailedQARun.stats.done}/${this.mostRecentNonFailedQARun.stats.found}`
} Pages`, } ${pluralOf("pages", this.mostRecentNonFailedQARun.stats.found)}`,
)}" )}"
placement="bottom" placement="bottom"
hoist hoist

2
frontend/src/pages/org/archived-item-qa/archived-item-qa.ts
View File

@ -355,7 +355,7 @@ export class ArchivedItemQA extends TailwindElement {
> >
<div class="flex items-center gap-2 overflow-hidden"> <div class="flex items-center gap-2 overflow-hidden">
<h2 <h2
class="flex-1 flex-shrink-0 basis-32 truncate text-base font-semibold leading-tight" class="flex-1 flex-shrink-0 min-w-32 truncate text-base font-semibold leading-tight"
> >
${itemName} ${itemName}
</h2> </h2>

2
frontend/src/pages/org/archived-item-qa/ui/screenshots.ts
View File

@ -11,7 +11,7 @@ import { renderSpinner } from "./spinner";
function image(data: ReplayData) { function image(data: ReplayData) {
if (!data?.blobUrl) { if (!data?.blobUrl) {
return html`<div return html`<div
class="flex h-full w-full flex-col items-center justify-center gap-2 text-xs text-neutral-500" class="flex aspect-video h-full w-full flex-col items-center justify-center gap-2 bg-slate-50 text-xs text-neutral-500"
> >
<sl-icon name="slash-circle"></sl-icon> <sl-icon name="slash-circle"></sl-icon>
${msg("Screenshot not available")} ${msg("Screenshot not available")}