tea/browsertrix
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Make crawlconfig name optional (#588)

Browse Source
This commit is contained in:
Tessa Walsh 2023-02-08 21:38:15 -05:00 committed by GitHub
parent ce8f426978
commit b642c53c59
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
backend/btrixcloud/crawlconfigs.py
View File

@ -119,7 +119,7 @@ class CrawlConfig(BaseMongoModel):
config: RawCrawlConfig config: RawCrawlConfig
name: str name: Optional[str]
jobType: Optional[JobType] = JobType.CUSTOM jobType: Optional[JobType] = JobType.CUSTOM
@ -317,7 +317,7 @@ class CrawlConfigOps:
"""Update name, scale, schedule, and/or tags for an existing crawl config""" """Update name, scale, schedule, and/or tags for an existing crawl config"""
# set update query # set update query
query = update.dict(exclude_unset=True, exclude_none=True) query = update.dict(exclude_unset=True)
if len(query) == 0: if len(query) == 0:
raise HTTPException(status_code=400, detail="no_update_data") raise HTTPException(status_code=400, detail="no_update_data")

6
backend/test/test_crawlconfigs.py
View File

@ -41,11 +41,11 @@ def test_add_update_crawl_config(
assert data["name"] == UPDATED_NAME assert data["name"] == UPDATED_NAME
assert sorted(data["tags"]) == sorted(UPDATED_TAGS) assert sorted(data["tags"]) == sorted(UPDATED_TAGS)
# Verify that deleting tags works as well # Verify that deleting tags and name works as well
r = requests.patch( r = requests.patch(
f"{API_PREFIX}/orgs/{default_org_id}/crawlconfigs/{cid}/", f"{API_PREFIX}/orgs/{default_org_id}/crawlconfigs/{cid}/",
headers=crawler_auth_headers, headers=crawler_auth_headers,
json={"tags": []}, json={"tags": [], "name": None},
) )
assert r.status_code == 200 assert r.status_code == 200
@ -56,5 +56,5 @@ def test_add_update_crawl_config(
assert r.status_code == 200 assert r.status_code == 200
data = r.json() data = r.json()
assert data["name"] == UPDATED_NAME assert not data["name"]
assert data["tags"] == [] assert data["tags"] == []