tea/browsertrix
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Workflow editor footer button: ensure isCrawlRunning is false if editing a new workflow (#2496)

Browse Source 
Reported by @tw4l 

Quick fix for the bug I introduced in 1bc3c35 in #2481. I didn't
properly test on the workflow editor in a "new workflow" state, and
didn't realize that the component that fetches the workflow state for an
existing workflow wouldn't be rendered for a new workflow, so the update
to the loading state never occurred for new workflows. This fix
explicitly sets `isCrawlRunning` to `false` instead of `null` for new
workflows, so that the loading state isn't displayed.

Tested locally with both new and existing workflows (in both non-running
and running states).
This commit is contained in:
Emma Segal-Grossman 2025-03-19 15:44:16 -04:00 committed by GitHub
parent 6be1f6674c
commit b471192cbc
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
frontend/src/features/crawl-workflows/workflow-editor.ts
View File

@ -227,7 +227,7 @@ export class WorkflowEditor extends BtrixElement {
private serverError?: TemplateResult | string;
@state()
private isCrawlRunning: boolean | null = null;
private isCrawlRunning: boolean | null = this.configId ? null : false;
// For observing panel sections position in viewport
private readonly observable = new ObservableController(this, {
@ -331,6 +331,9 @@ export class WorkflowEditor extends BtrixElement {
this.initializeEditor();
}
}
if (changedProperties.has("configId")) {
this.isCrawlRunning = this.configId ? null : false;
}
}
updated(changedProperties: PropertyValues<this> & Map<string, unknown>) {