hotfix: workflow list - rewrite arrays in url search params to remove items (#2734)
## Changes - Deletes and rewrites arrays in URL search params in workflow list when editing array filters (i.e. tags & profiles) - Removes a missed `console.log` - bump to 1.17.3 cc @SuaYoo --------- Co-authored-by: Ilya Kreymer <ikreymer@gmail.com>
This commit is contained in:
parent
b3c8cc5994
commit
b0f2d87ce2
@ -1,3 +1,3 @@
|
|||||||
"""current version"""
|
"""current version"""
|
||||||
|
|
||||||
__version__ = "1.17.2"
|
__version__ = "1.17.3"
|
||||||
|
@ -5,7 +5,7 @@ type: application
|
|||||||
icon: https://webrecorder.net/assets/icon.png
|
icon: https://webrecorder.net/assets/icon.png
|
||||||
|
|
||||||
# Browsertrix and Chart Version
|
# Browsertrix and Chart Version
|
||||||
version: v1.17.2
|
version: v1.17.3
|
||||||
|
|
||||||
dependencies:
|
dependencies:
|
||||||
- name: btrix-admin-logging
|
- name: btrix-admin-logging
|
||||||
|
@ -106,7 +106,7 @@ replica_deletion_delay_days: 0
|
|||||||
|
|
||||||
# API Image
|
# API Image
|
||||||
# =========================================
|
# =========================================
|
||||||
backend_image: "docker.io/webrecorder/browsertrix-backend:1.17.2"
|
backend_image: "docker.io/webrecorder/browsertrix-backend:1.17.3"
|
||||||
backend_pull_policy: "IfNotPresent"
|
backend_pull_policy: "IfNotPresent"
|
||||||
|
|
||||||
backend_password_secret: "PASSWORD!"
|
backend_password_secret: "PASSWORD!"
|
||||||
@ -164,7 +164,7 @@ backend_avg_memory_threshold: 95
|
|||||||
|
|
||||||
# Nginx Image
|
# Nginx Image
|
||||||
# =========================================
|
# =========================================
|
||||||
frontend_image: "docker.io/webrecorder/browsertrix-frontend:1.17.2"
|
frontend_image: "docker.io/webrecorder/browsertrix-frontend:1.17.3"
|
||||||
frontend_pull_policy: "IfNotPresent"
|
frontend_pull_policy: "IfNotPresent"
|
||||||
|
|
||||||
frontend_cpu: "10m"
|
frontend_cpu: "10m"
|
||||||
|
@ -1,6 +1,6 @@
|
|||||||
{
|
{
|
||||||
"name": "browsertrix-frontend",
|
"name": "browsertrix-frontend",
|
||||||
"version": "1.17.2",
|
"version": "1.17.3",
|
||||||
"main": "index.ts",
|
"main": "index.ts",
|
||||||
"license": "AGPL-3.0-or-later",
|
"license": "AGPL-3.0-or-later",
|
||||||
"dependencies": {
|
"dependencies": {
|
||||||
|
@ -106,8 +106,6 @@ export class WorkflowTagFilter extends BtrixElement {
|
|||||||
@sl-after-hide=${() => {
|
@sl-after-hide=${() => {
|
||||||
this.searchString = "";
|
this.searchString = "";
|
||||||
|
|
||||||
console.log("after hide");
|
|
||||||
|
|
||||||
this.dispatchEvent(
|
this.dispatchEvent(
|
||||||
new CustomEvent<
|
new CustomEvent<
|
||||||
BtrixChangeEvent<ChangeWorkflowTagEventDetails>["detail"]
|
BtrixChangeEvent<ChangeWorkflowTagEventDetails>["detail"]
|
||||||
|
@ -354,11 +354,13 @@ export class WorkflowsList extends BtrixElement {
|
|||||||
for (const [filter, value] of newParams) {
|
for (const [filter, value] of newParams) {
|
||||||
if (value !== undefined) {
|
if (value !== undefined) {
|
||||||
if (Array.isArray(value)) {
|
if (Array.isArray(value)) {
|
||||||
|
// Rather than a more efficient method where we compare the existing & wanted arrays,
|
||||||
|
// it's simpler to just delete and re-append values here. If we were working with large
|
||||||
|
// arrays, we could change this, but we'll leave it as is for now — if we were working
|
||||||
|
// with truly large arrays, we wouldn't be using search params anyways.
|
||||||
|
params.delete(filter);
|
||||||
value.forEach((v) => {
|
value.forEach((v) => {
|
||||||
// Only add new array values to URL
|
|
||||||
if (!params.getAll(filter).includes(v)) {
|
|
||||||
params.append(filter, v);
|
params.append(filter, v);
|
||||||
}
|
|
||||||
});
|
});
|
||||||
} else {
|
} else {
|
||||||
params.set(filter, value.toString());
|
params.set(filter, value.toString());
|
||||||
|
@ -1 +1 @@
|
|||||||
1.17.2
|
1.17.3
|
||||||
|
Loading…
Reference in New Issue
Block a user