From 9597cb1062f9260adc039bcf86cf383b8c95b046 Mon Sep 17 00:00:00 2001 From: sua yoo Date: Tue, 17 Dec 2024 09:29:51 -0800 Subject: [PATCH] chore: Prevent blocking connected callback (#2244) Moves language initialization to `willUpdate` to prevent blocking connected callback and attaching listeners --- .vscode/snippets.code-snippets | 2 +- frontend/src/index.ejs | 1 + frontend/src/index.test.ts | 28 +++++++++++++++++++---- frontend/src/index.ts | 42 ++++++++++++++++++++++------------ frontend/src/utils/localize.ts | 10 +++++++- 5 files changed, 61 insertions(+), 22 deletions(-) diff --git a/.vscode/snippets.code-snippets b/.vscode/snippets.code-snippets index 483f35be..777a1dfa 100644 --- a/.vscode/snippets.code-snippets +++ b/.vscode/snippets.code-snippets @@ -9,8 +9,8 @@ "", "import { BtrixElement } from \"@/classes/BtrixElement\";", "", - "@localized()", "@customElement(\"btrix-${1:component}\")", + "@localized()", "export class ${2:Component} extends BtrixElement {", "\trender() {", "\t\treturn html``;", diff --git a/frontend/src/index.ejs b/frontend/src/index.ejs index 3c181f77..c411ae8a 100644 --- a/frontend/src/index.ejs +++ b/frontend/src/index.ejs @@ -22,6 +22,7 @@