Fix archived item status icon size + minor review UI updates (#1734)
Related to https://github.com/webrecorder/browsertrix/issues/1477, minor UI tweaks as fast follow: - Makes archived item status icons all the same size - Increases hover hit target of archived item cells - Reduces top padding of QA review page - Adds "Back" button to QA review page to match all other pages - Updates percentage formatting of tab labels to match pages
This commit is contained in:
parent
1915274e26
commit
7ac06608b2
@ -154,6 +154,7 @@ export class ArchivedItemListItem extends TailwindElement {
|
|||||||
@sl-after-hide=${(e: SlHideEvent) => e.stopPropagation()}
|
@sl-after-hide=${(e: SlHideEvent) => e.stopPropagation()}
|
||||||
>
|
>
|
||||||
<sl-icon
|
<sl-icon
|
||||||
|
class="text-base"
|
||||||
style="color: ${crawlStatus.cssColor}"
|
style="color: ${crawlStatus.cssColor}"
|
||||||
name=${typeIcon}
|
name=${typeIcon}
|
||||||
label=${typeLabel}
|
label=${typeLabel}
|
||||||
@ -276,11 +277,11 @@ export class ArchivedItemListItem extends TailwindElement {
|
|||||||
str`Last run started on ${formatISODateString(lastQAStarted)}`,
|
str`Last run started on ${formatISODateString(lastQAStarted)}`,
|
||||||
)}
|
)}
|
||||||
>
|
>
|
||||||
<span>
|
<div class="min-w-4">
|
||||||
${formatNumber(qaRunCount, {
|
${formatNumber(qaRunCount, {
|
||||||
notation: "compact",
|
notation: "compact",
|
||||||
})}
|
})}
|
||||||
</span>
|
</div>
|
||||||
</sl-tooltip>
|
</sl-tooltip>
|
||||||
`
|
`
|
||||||
: none}
|
: none}
|
||||||
|
|||||||
@ -330,18 +330,35 @@ export class ArchivedItemQA extends TailwindElement {
|
|||||||
return html`
|
return html`
|
||||||
${this.renderHidden()}
|
${this.renderHidden()}
|
||||||
|
|
||||||
<btrix-beta-badge placement="right"></btrix-beta-badge>
|
<div class="flex items-center gap-2">
|
||||||
|
<a
|
||||||
|
class="font-medium text-neutral-500 hover:text-neutral-600"
|
||||||
|
href=${`${crawlBaseUrl}#qa`}
|
||||||
|
@click=${this.navigate.link}
|
||||||
|
>
|
||||||
|
<sl-icon
|
||||||
|
name="arrow-left"
|
||||||
|
class="inline-block align-middle"
|
||||||
|
></sl-icon>
|
||||||
|
<span class="inline-block align-middle"> ${msg("Back")} </span>
|
||||||
|
</a>
|
||||||
|
<div class="text-neutral-400" role="separator">/</div>
|
||||||
|
<h1 class="text-neutral-400">
|
||||||
|
${msg("Review Archived Item")}
|
||||||
|
<btrix-beta-badge placement="right"></btrix-beta-badge>
|
||||||
|
</h1>
|
||||||
|
</div>
|
||||||
|
|
||||||
<article class="qa-grid grid gap-x-6 gap-y-0">
|
<article class="qa-grid grid gap-x-6 gap-y-0">
|
||||||
<header
|
<header
|
||||||
class="grid--header flex flex-wrap items-center justify-between gap-1 border-b py-2"
|
class="grid--header flex flex-wrap items-center justify-between gap-1 border-b py-2"
|
||||||
>
|
>
|
||||||
<div class="flex items-center gap-2 overflow-hidden">
|
<div class="flex items-center gap-2 overflow-hidden">
|
||||||
<h1
|
<h2
|
||||||
class="flex-1 flex-shrink-0 basis-32 truncate text-base font-semibold leading-tight"
|
class="flex-1 flex-shrink-0 basis-32 truncate text-base font-semibold leading-tight"
|
||||||
>
|
>
|
||||||
${itemName}
|
${itemName}
|
||||||
</h1>
|
</h2>
|
||||||
${when(
|
${when(
|
||||||
this.finishedQARuns,
|
this.finishedQARuns,
|
||||||
(qaRuns) => html`
|
(qaRuns) => html`
|
||||||
@ -389,15 +406,15 @@ export class ArchivedItemQA extends TailwindElement {
|
|||||||
<div
|
<div
|
||||||
class="grid--pageToolbar flex flex-wrap items-center justify-stretch gap-2 overflow-hidden border-b py-2 @container"
|
class="grid--pageToolbar flex flex-wrap items-center justify-stretch gap-2 overflow-hidden border-b py-2 @container"
|
||||||
>
|
>
|
||||||
<h2
|
<h3
|
||||||
class="flex-auto flex-shrink-0 flex-grow basis-32 truncate text-base font-semibold text-neutral-700"
|
class="flex-auto flex-shrink-0 flex-grow basis-32 truncate text-base font-semibold text-neutral-700"
|
||||||
title="${this.page?.title ?? ""}"
|
title="${this.page?.title ?? ""}"
|
||||||
>
|
>
|
||||||
${
|
${
|
||||||
this.page?.title ||
|
this.page?.title ||
|
||||||
html`<span class="opacity-50">${msg("No page title")}</span>`
|
html`<span class="opacity-50">${msg("No page title")}</span>`
|
||||||
}
|
}
|
||||||
</h2>
|
</h3>
|
||||||
<div
|
<div
|
||||||
class="ml-auto flex flex-grow basis-auto flex-wrap justify-between gap-2 @lg:flex-grow-0"
|
class="ml-auto flex flex-grow basis-auto flex-wrap justify-between gap-2 @lg:flex-grow-0"
|
||||||
>
|
>
|
||||||
@ -495,11 +512,11 @@ export class ArchivedItemQA extends TailwindElement {
|
|||||||
<section
|
<section
|
||||||
class="grid--pageList grid grid-rows-[auto_1fr] *:min-h-0 *:min-w-0"
|
class="grid--pageList grid grid-rows-[auto_1fr] *:min-h-0 *:min-w-0"
|
||||||
>
|
>
|
||||||
<h2
|
<h3
|
||||||
class="my-4 text-base font-semibold leading-none text-neutral-800"
|
class="my-4 text-base font-semibold leading-none text-neutral-800"
|
||||||
>
|
>
|
||||||
${msg("Pages")}
|
${msg("Pages")}
|
||||||
</h2>
|
</h3>
|
||||||
<btrix-qa-page-list
|
<btrix-qa-page-list
|
||||||
class="flex flex-col"
|
class="flex flex-col"
|
||||||
.qaRunId=${this.qaRunId}
|
.qaRunId=${this.qaRunId}
|
||||||
|
|||||||
@ -26,6 +26,6 @@ export function renderSeverityBadge(value?: number | null) {
|
|||||||
}
|
}
|
||||||
|
|
||||||
return html`
|
return html`
|
||||||
<btrix-badge variant=${variant}>${formatPercentage(value)}%</btrix-badge>
|
<btrix-badge variant=${variant}>${formatPercentage(value, 0)}%</btrix-badge>
|
||||||
`;
|
`;
|
||||||
}
|
}
|
||||||
|
|||||||
@ -304,7 +304,7 @@ export class Org extends LiteElement {
|
|||||||
<main
|
<main
|
||||||
class="${noMaxWidth
|
class="${noMaxWidth
|
||||||
? "w-full"
|
? "w-full"
|
||||||
: "w-full max-w-screen-desktop"} mx-auto box-border flex flex-1 flex-col p-3 pt-7"
|
: "w-full max-w-screen-desktop pt-7"} mx-auto box-border flex flex-1 flex-col p-3"
|
||||||
aria-labelledby="${this.orgTab}-tab"
|
aria-labelledby="${this.orgTab}-tab"
|
||||||
>
|
>
|
||||||
${tabPanelContent}
|
${tabPanelContent}
|
||||||
|
|||||||
Loading…
Reference in New Issue
Block a user