tea/browsertrix
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: Use correct job type in crawl settings (#2028)

Browse Source 
Fixes https://github.com/webrecorder/browsertrix/issues/2027

### Changes

Fixes crawl settings for archived item not showing the correct fields
based on job type.
This commit is contained in:
sua yoo 2024-08-19 18:10:52 -07:00 committed by GitHub
parent 4c7f1aa3ca
commit 6ce565b5f7
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 19 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

28
frontend/src/pages/org/archived-item-detail/archived-item-detail.ts
View File

@ -90,7 +90,7 @@ export class ArchivedItemDetail extends BtrixElement {
qaRuns?: QARun[];
@state()
private crawl?: ArchivedItem;
crawl?: ArchivedItem;
@state()
private workflow?: Workflow;
@ -159,7 +159,10 @@ export class ArchivedItemDetail extends BtrixElement {
void this.fetchQARuns();
}
}
if (changedProperties.has("workflowId") && this.workflowId) {
if (
(changedProperties.has("workflowId") && this.workflowId) ||
(changedProperties.has("crawl") && this.crawl?.cid)
) {
void this.fetchWorkflow();
}
if (changedProperties.has("qaRuns")) {
@ -1004,7 +1007,7 @@ ${this.crawl?.description}
return html`
<div aria-live="polite" aria-busy=${!this.crawl || !this.seeds}>
${when(
this.crawl && this.seeds && (!this.workflowId || this.workflow),
this.crawl && this.seeds && this.workflow,
() => html`
<btrix-config-details
.crawlConfig=${{
@ -1177,9 +1180,18 @@ ${this.crawl?.description}
private async fetchWorkflow(): Promise<void> {
try {
this.workflow = await this.getWorkflow();
const id = this.workflowId || this.crawl?.cid;
if (!id) {
console.debug("no workflow id");
return;
}
this.workflow = await this.getWorkflow(id);
} catch (e: unknown) {
console.debug(e);
this.notify.toast({
message: msg("Sorry, couldn't load all crawl settings."),
variant: "warning",
icon: "exclamation-circle",
});
}
}
@ -1198,10 +1210,8 @@ ${this.crawl?.description}
return data;
}
private async getWorkflow(): Promise<Workflow> {
return this.api.fetch<Workflow>(
`/orgs/${this.orgId}/crawlconfigs/${this.workflowId}`,
);
private async getWorkflow(id: string): Promise<Workflow> {
return this.api.fetch<Workflow>(`/orgs/${this.orgId}/crawlconfigs/${id}`);
}
private async fetchCrawlLogs(