tea/browsertrix
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix text overflow problem on crawl details page (#570)

Browse Source 
* Fixes text overflow problem on crawl details page

- Crawl title length is now unlimited
- Flex items in that row are aligned to the bottom of the box (details bar) instead of the top
- Mirrors changes on config detail page

* Shrinks action button size on config detail page: Matches crawl detail page
* Margin fix: Added 0.5rem, aligned with mockups
This commit is contained in:
Henry Wilkinson 2023-02-06 22:43:22 -05:00 committed by GitHub
parent d128525e4e
commit 56d331ab78
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
frontend/src/pages/org/crawl-configs-detail.ts
View File

@ -95,7 +95,7 @@ export class CrawlTemplatesDetail extends LiteElement {
<h2> <h2>
${this.crawlConfig?.name ${this.crawlConfig?.name
? html`<span ? html`<span
class="inline-block align-middle text-xl font-semibold leading-10 mr-1" class="inline-block align-middle text-xl font-semibold leading-10 md:mr-2"
>${this.crawlConfig.name}</span >${this.crawlConfig.name}</span
> ` > `
: ""} : ""}
@ -117,6 +117,7 @@ export class CrawlTemplatesDetail extends LiteElement {
this.crawlConfig!.id this.crawlConfig!.id
}?edit`} }?edit`}
variant="primary" variant="primary"
size="small"
class="mr-2" class="mr-2"
@click=${this.navLink} @click=${this.navLink}
> >
@ -298,7 +299,7 @@ export class CrawlTemplatesDetail extends LiteElement {
return html` return html`
<sl-dropdown placement="bottom-end" distance="4"> <sl-dropdown placement="bottom-end" distance="4">
<sl-button slot="trigger" caret>${msg("Actions")}</sl-button> <sl-button slot="trigger" size="small" caret>${msg("Actions")}</sl-button>
<ul <ul
class="text-left text-sm text-neutral-800 bg-white whitespace-nowrap" class="text-left text-sm text-neutral-800 bg-white whitespace-nowrap"

6
frontend/src/pages/org/crawl-detail.ts
View File

@ -242,7 +242,7 @@ export class CrawlDetail extends LiteElement {
</a> </a>
</div> </div>
<div class="mb-2">${this.renderHeader()}</div> <div class="mb-4">${this.renderHeader()}</div>
<main> <main>
<section class="rounded-lg border mb-7"> <section class="rounded-lg border mb-7">
@ -329,8 +329,8 @@ export class CrawlDetail extends LiteElement {
private renderHeader() { private renderHeader() {
return html` return html`
<header class="md:flex justify-between"> <header class="md:flex justify-between items-end">
<h2 class="text-xl font-semibold mb-3 md:h-8"> <h2 class="text-xl font-semibold mb-3 md:mr-2">
${msg( ${msg(
html`${this.crawl html`${this.crawl
? this.crawl.configName ? this.crawl.configName