From 3de2e486b1a083d87c44bd5b62309a2fcc56655e Mon Sep 17 00:00:00 2001 From: Henry Wilkinson Date: Wed, 12 Jun 2024 11:46:15 -0400 Subject: [PATCH] Reorder sections to match workflow creator (#1862) --- frontend/src/components/ui/config-details.ts | 40 ++++++++++++-------- 1 file changed, 25 insertions(+), 15 deletions(-) diff --git a/frontend/src/components/ui/config-details.ts b/frontend/src/components/ui/config-details.ts index 35158b4e..6c8a3e93 100644 --- a/frontend/src/components/ui/config-details.ts +++ b/frontend/src/components/ui/config-details.ts @@ -141,6 +141,9 @@ export class ConfigDetails extends LiteElement { `, () => this.renderSetting(msg("Exclusions"), msg("None")), )} + +

${msg("Per-Crawl Limits")}

+
${this.renderSetting( msg("Max Pages"), when( @@ -157,6 +160,21 @@ export class ConfigDetails extends LiteElement { : undefined, ), )} + ${this.renderSetting( + msg("Crawl Time Limit"), + renderTimeLimit(crawlConfig?.crawlTimeout, Infinity), + )} + ${this.renderSetting( + msg("Crawl Size Limit"), + renderSize(crawlConfig?.maxCrawlSize), + )} + ${this.renderSetting( + msg("Crawler Instances"), + crawlConfig?.scale ? `${crawlConfig.scale}×` : "", + )} + +

${msg("Per-Page Limits")}

+
${this.renderSetting( msg("Page Load Timeout"), renderTimeLimit( @@ -169,7 +187,7 @@ export class ConfigDetails extends LiteElement { renderTimeLimit(crawlConfig?.config.postLoadDelay, 0), )} ${this.renderSetting( - msg("Page Behavior Timeout"), + msg("Behavior Timeout"), renderTimeLimit( crawlConfig?.config.behaviorTimeout, this.orgDefaults?.behaviorTimeoutSeconds ?? Infinity, @@ -188,18 +206,6 @@ export class ConfigDetails extends LiteElement { msg("Delay Before Next Page"), renderTimeLimit(crawlConfig?.config.pageExtraDelay, 0), )} - ${this.renderSetting( - msg("Crawl Time Limit"), - renderTimeLimit(crawlConfig?.crawlTimeout, Infinity), - )} - ${this.renderSetting( - msg("Crawl Size Limit"), - renderSize(crawlConfig?.maxCrawlSize), - )} - ${this.renderSetting( - msg("Crawler Instances"), - crawlConfig?.scale ? `${crawlConfig.scale}×` : "", - )}
@@ -221,7 +227,11 @@ export class ConfigDetails extends LiteElement { > ${crawlConfig?.profileName} `, - () => crawlConfig?.profileName || msg("Default Profile"), + () => + crawlConfig?.profileName || + html`${msg("Default Profile")}`, ), )} ${this.renderSetting( @@ -237,7 +247,7 @@ export class ConfigDetails extends LiteElement { msg("User Agent"), crawlConfig?.config.userAgent ? crawlConfig.config.userAgent - : msg("Default User Agent"), + : html`${msg("Default")}`, )} ${crawlConfig?.config.lang ? this.renderSetting(