From 7f3cdad5b987df5c88b6e84f3cb0ff7b70fe4648 Mon Sep 17 00:00:00 2001 From: Henry Wilkinson Date: Fri, 24 Feb 2023 00:02:49 -0500 Subject: [PATCH 1/4] Adds page titles, edits heading hierarchy MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ### Main Pages + General - Adds H1 page titles for all main pages - Moves the New Crawl Config action into the title row from the search controls box - Gives the Crawl Config search controls box the same style as the Crawls search controls box - Adds +8px of padding to the search controls box to match mockups - Search box: medium → small - Title row control buttons: medium → small ### Details Pages - h2 → h1 for crawl config and crawl detail pages - h3 → h2 for crawl config and crawl detail pages - Removes crawl title margin bottom at medium breakpoint on crawl details page - Aligns crawl config details title row controls with end of flexbox on mobile to match crawl details controls in the same spot --- .../src/pages/org/browser-profiles-list.ts | 6 +++- .../src/pages/org/crawl-configs-detail.ts | 2 +- frontend/src/pages/org/crawl-configs-list.ts | 28 +++++++++++-------- frontend/src/pages/org/crawl-detail.ts | 6 ++-- frontend/src/pages/org/crawls-list.ts | 14 +++++++--- frontend/src/pages/org/settings.ts | 2 +- 6 files changed, 36 insertions(+), 22 deletions(-) diff --git a/frontend/src/pages/org/browser-profiles-list.ts b/frontend/src/pages/org/browser-profiles-list.ts index 5f49849f..f6bb0e9a 100644 --- a/frontend/src/pages/org/browser-profiles-list.ts +++ b/frontend/src/pages/org/browser-profiles-list.ts @@ -43,15 +43,19 @@ export class BrowserProfilesList extends LiteElement { } render() { - return html`
+ return html`
+
+

${msg("Browser Profiles")}

${msg("New Browser Profile")} +
${this.renderTable()} diff --git a/frontend/src/pages/org/crawl-configs-detail.ts b/frontend/src/pages/org/crawl-configs-detail.ts index 7f05234b..7ce3b951 100644 --- a/frontend/src/pages/org/crawl-configs-detail.ts +++ b/frontend/src/pages/org/crawl-configs-detail.ts @@ -108,7 +108,7 @@ export class CrawlTemplatesDetail extends LiteElement { ` )} -
+
${when( this.crawlConfig && !this.crawlConfig.inactive, () => html` diff --git a/frontend/src/pages/org/crawl-configs-list.ts b/frontend/src/pages/org/crawl-configs-list.ts index 0c151f9e..6cc5450a 100644 --- a/frontend/src/pages/org/crawl-configs-list.ts +++ b/frontend/src/pages/org/crawl-configs-list.ts @@ -109,9 +109,23 @@ export class CrawlTemplatesList extends LiteElement { render() { return html` -
+
+
+

${msg("Crawl Configs")}

+ + + ${msg("New Crawl Config")} + +
+
${this.renderControls()}
+
${this.crawlTemplates ? this.crawlTemplates.length @@ -158,6 +172,7 @@ export class CrawlTemplatesList extends LiteElement {
- -
- - - ${msg("New Crawl Config")} - -
diff --git a/frontend/src/pages/org/crawl-detail.ts b/frontend/src/pages/org/crawl-detail.ts index f2c4be2f..8a047a1d 100644 --- a/frontend/src/pages/org/crawl-detail.ts +++ b/frontend/src/pages/org/crawl-detail.ts @@ -343,7 +343,7 @@ export class CrawlDetail extends LiteElement { private renderHeader() { return html`
-

+

${msg( html`${this.crawl ? this.crawl.configName @@ -352,7 +352,7 @@ export class CrawlDetail extends LiteElement { style="width: 15em" >`}` )} -

+
${title} +

${title}

${content}
`; } diff --git a/frontend/src/pages/org/crawls-list.ts b/frontend/src/pages/org/crawls-list.ts index 9a181d62..384acdd1 100644 --- a/frontend/src/pages/org/crawls-list.ts +++ b/frontend/src/pages/org/crawls-list.ts @@ -217,10 +217,15 @@ export class CrawlsList extends LiteElement { return html`
-
- ${this.renderControls()} +
+
+

${msg("Crawls")}

+
+
+ ${this.renderControls()} +
${this.crawls.length @@ -261,6 +266,7 @@ export class CrawlsList extends LiteElement {
-

${msg("Org Settings")}

+

${msg("Org Settings")}

From d0abf2b3248362b6a8197ec155777637e25bb57c Mon Sep 17 00:00:00 2001 From: Henry Wilkinson Date: Fri, 24 Feb 2023 00:10:16 -0500 Subject: [PATCH 2/4] Fix crawl config grid on sm - Improves grid breakpoints on md --- frontend/src/pages/org/crawl-configs-list.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/frontend/src/pages/org/crawl-configs-list.ts b/frontend/src/pages/org/crawl-configs-list.ts index 6cc5450a..bd1c44d6 100644 --- a/frontend/src/pages/org/crawl-configs-list.ts +++ b/frontend/src/pages/org/crawl-configs-list.ts @@ -302,7 +302,7 @@ export class CrawlTemplatesList extends LiteElement { } return html` -
+
${flow(...flowFns)(this.crawlTemplates)}
`; From 133d8b10ab57453b22aabdcaac490b71ccb959e5 Mon Sep 17 00:00:00 2001 From: Henry Wilkinson Date: Fri, 24 Feb 2023 00:25:16 -0500 Subject: [PATCH 3/4] Removes H1 from nav bar Accessibility improvement, better for screen readers to have h1 be the content of the page as opposed to the application / brand name. Rest of the nav bar to be dealt with at a later date. --- frontend/src/index.ts | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/frontend/src/index.ts b/frontend/src/index.ts index 2acdfd31..f32ea0eb 100644 --- a/frontend/src/index.ts +++ b/frontend/src/index.ts @@ -274,6 +274,7 @@ export class App extends LiteElement { > ${isAdmin From d36d22fea3c6cff61b873589c512e4dec34e99e8 Mon Sep 17 00:00:00 2001 From: Henry Wilkinson Date: Fri, 24 Feb 2023 16:20:32 -0500 Subject: [PATCH 4/4] Run prettier on crawl-configs-list.ts --- frontend/src/pages/org/crawl-configs-list.ts | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/frontend/src/pages/org/crawl-configs-list.ts b/frontend/src/pages/org/crawl-configs-list.ts index bd1c44d6..55967ebe 100644 --- a/frontend/src/pages/org/crawl-configs-list.ts +++ b/frontend/src/pages/org/crawl-configs-list.ts @@ -109,10 +109,10 @@ export class CrawlTemplatesList extends LiteElement { render() { return html` -
-
-

${msg("Crawl Configs")}

- +
+

${msg("Crawl Configs")}

+ ${msg("New Crawl Config")} -
-
- ${this.renderControls()} -
-
+
+
+ ${this.renderControls()} +
+
${this.crawlTemplates ? this.crawlTemplates.length