From 26820cbaba80c3c835c7199e20876505c50f9bf0 Mon Sep 17 00:00:00 2001
From: sua yoo <sua@webrecorder.org>
Date: Tue, 19 Mar 2024 13:02:08 -0700
Subject: [PATCH] Upgrade Node 16 > 18 (#1612)

---
 .github/workflows/frontend-build-check.yaml |  2 +-
 .github/workflows/ui-tests-playwright.yml   |  2 +-
 frontend/Dockerfile                         | 22 ++++++++++-----------
 frontend/package.json                       |  2 +-
 4 files changed, 14 insertions(+), 14 deletions(-)

diff --git a/.github/workflows/frontend-build-check.yaml b/.github/workflows/frontend-build-check.yaml
index a7f802aa..de046e89 100644
--- a/.github/workflows/frontend-build-check.yaml
+++ b/.github/workflows/frontend-build-check.yaml
@@ -15,7 +15,7 @@ jobs:
       - name: Setup Node
         uses: actions/setup-node@v3
         with:
-          node-version: '16'
+          node-version: '18'
           cache: 'yarn'
           cache-dependency-path: frontend/yarn.lock
       - name: Restore cache
diff --git a/.github/workflows/ui-tests-playwright.yml b/.github/workflows/ui-tests-playwright.yml
index 4fd201b8..4ae8484b 100644
--- a/.github/workflows/ui-tests-playwright.yml
+++ b/.github/workflows/ui-tests-playwright.yml
@@ -22,7 +22,7 @@ jobs:
       - name: Setup Node
         uses: actions/setup-node@v3
         with:
-          node-version: '16'
+          node-version: '18'
           cache: 'yarn'
           cache-dependency-path: frontend/yarn.lock
       - name: Install dependencies
diff --git a/frontend/Dockerfile b/frontend/Dockerfile
index e3ce8008..fd3f435e 100644
--- a/frontend/Dockerfile
+++ b/frontend/Dockerfile
@@ -1,21 +1,21 @@
 # syntax=docker/dockerfile:1.4
-FROM --platform=$BUILDPLATFORM docker.io/library/node:16 as build_deps
+FROM --platform=$BUILDPLATFORM docker.io/library/node:18 as build_deps
 
 WORKDIR /app
 COPY yarn.lock package.json ./
 # Uses `yarn cache clean` to let Docker cache layer instead
 # of including yarn cache in the build image
 RUN yarn --production --frozen-lockfile --ignore-optional --network-timeout 1000000 && \
-    yarn cache clean
+  yarn cache clean
 
 COPY --link lit-localize.json \
-    postcss.config.js \
-    tailwind.config.js \
-    tsconfig.json \
-    webpack.config.js \
-    webpack.prod.js \
-    index.d.ts \
-    ./
+  postcss.config.js \
+  tailwind.config.js \
+  tsconfig.json \
+  webpack.config.js \
+  webpack.prod.js \
+  index.d.ts \
+  ./
 
 COPY --link src ./src/
 
@@ -27,8 +27,8 @@ ARG GIT_BRANCH_NAME
 ARG VERSION
 
 ENV GIT_COMMIT_HASH=${GIT_COMMIT_HASH} \
-    GIT_BRANCH_NAME=${GIT_BRANCH_NAME} \
-    VERSION=${VERSION}
+  GIT_BRANCH_NAME=${GIT_BRANCH_NAME} \
+  VERSION=${VERSION}
 
 # Prevent Docker image including node_modules to save space
 RUN yarn build && \
diff --git a/frontend/package.json b/frontend/package.json
index ae52bc63..51fc7323 100644
--- a/frontend/package.json
+++ b/frontend/package.json
@@ -127,7 +127,7 @@
     }
   },
   "engines": {
-    "node": ">=16"
+    "node": ">=18"
   },
   "resolutions": {
     "**/playwright": "1.32.1",