tea/browsertrix
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

feat: Enable deleting workflow from list (#2042)

Browse Source 
Adds back workflow list menu item to delete workflow if it's never been
run.
This commit is contained in:
sua yoo 2024-08-21 15:33:00 -07:00 committed by GitHub
parent 2ca9632057
commit 25b1928d44
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 29 additions and 77 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

61
frontend/src/pages/org/workflow-detail.ts
View File

@ -702,24 +702,19 @@ export class WorkflowDetail extends LiteElement {
<sl-icon name="files" slot="prefix"></sl-icon>
${msg("Duplicate Workflow")}
</sl-menu-item>
${when(!this.lastCrawlId, () => {
const shouldDeactivate = workflow.crawlCount && !workflow.inactive;
return html`
${when(
!this.lastCrawlId,
() => html`
<sl-divider></sl-divider>
<sl-menu-item
style="--sl-color-neutral-700: var(--danger)"
@click=${() =>
shouldDeactivate
? void this.deactivate()
: void this.delete()}
@click=${() => void this.delete()}
>
<sl-icon name="trash3" slot="prefix"></sl-icon>
${shouldDeactivate
? msg("Deactivate Workflow")
: msg("Delete Workflow")}
${msg("Delete Workflow")}
</sl-menu-item>
`;
})}
`,
)}
</sl-menu>
</sl-dropdown>
`;
@ -1477,41 +1472,9 @@ export class WorkflowDetail extends LiteElement {
});
}
private async deactivate(): Promise<void> {
if (!this.workflow) return;
try {
await this.apiFetch(
`/orgs/${this.orgId}/crawlconfigs/${this.workflow.id}`,
{
method: "DELETE",
},
);
this.workflow = {
...this.workflow,
inactive: true,
};
this.notify({
message: msg(html`Deactivated <strong>${this.renderName()}</strong>.`),
variant: "success",
icon: "check2-circle",
});
} catch {
this.notify({
message: msg("Sorry, couldn't deactivate Workflow at this time."),
variant: "danger",
icon: "exclamation-octagon",
});
}
}
private async delete(): Promise<void> {
if (!this.workflow) return;
const isDeactivating = this.workflow.crawlCount > 0;
try {
await this.apiFetch(
`/orgs/${this.orgId}/crawlconfigs/${this.workflow.id}`,
@ -1523,17 +1486,15 @@ export class WorkflowDetail extends LiteElement {
this.navTo(`${this.orgBasePath}/workflows/crawls`);
this.notify({
message: isDeactivating
? msg(html`Deactivated <strong>${this.renderName()}</strong>.`)
: msg(html`Deleted <strong>${this.renderName()}</strong>.`),
message: msg(
html`Deleted <strong>${this.renderName()}</strong> Workflow.`,
),
variant: "success",
icon: "check2-circle",
});
} catch {
this.notify({
message: isDeactivating
? msg("Sorry, couldn't deactivate Workflow at this time.")
: msg("Sorry, couldn't delete Workflow at this time."),
message: msg("Sorry, couldn't delete Workflow at this time."),
variant: "danger",
icon: "exclamation-octagon",
});

45
frontend/src/pages/org/workflows-list.ts
View File

@ -500,14 +500,28 @@ export class WorkflowsList extends LiteElement {
</sl-menu-item>
${when(
this.appState.isCrawler,
() =>
html` <sl-menu-item
() => html`
<sl-menu-item
?disabled=${isArchivingDisabled(this.org, true)}
@click=${() => void this.duplicateConfig(workflow)}
>
<sl-icon name="files" slot="prefix"></sl-icon>
${msg("Duplicate Workflow")}
</sl-menu-item>`,
</sl-menu-item>
${when(
!workflow.lastCrawlId,
() => html`
<sl-divider></sl-divider>
<sl-menu-item
style="--sl-color-neutral-700: var(--danger)"
@click=${() => void this.delete(workflow)}
>
<sl-icon name="trash3" slot="prefix"></sl-icon>
${msg("Delete Workflow")}
</sl-menu-item>
`,
)}
`,
)}
`;
}
@ -656,29 +670,6 @@ export class WorkflowsList extends LiteElement {
}
}
private async deactivate(workflow: ListWorkflow): Promise<void> {
try {
await this.apiFetch(`/orgs/${this.orgId}/crawlconfigs/${workflow.id}`, {
method: "DELETE",
});
void this.fetchWorkflows();
this.notify({
message: msg(
html`Deactivated <strong>${this.renderName(workflow)}</strong>.`,
),
variant: "success",
icon: "check2-circle",
});
} catch {
this.notify({
message: msg("Sorry, couldn't deactivate Workflow at this time."),
variant: "danger",
icon: "exclamation-octagon",
});
}
}
private async delete(workflow: ListWorkflow): Promise<void> {
try {
await this.apiFetch(`/orgs/${this.orgId}/crawlconfigs/${workflow.id}`, {
@ -688,7 +679,7 @@ export class WorkflowsList extends LiteElement {
void this.fetchWorkflows();
this.notify({
message: msg(
html`Deleted <strong>${this.renderName(workflow)}</strong>.`,
html`Deleted <strong>${this.renderName(workflow)}</strong> Workflow.`,
),
variant: "success",
icon: "check2-circle",