From 0e16d526c05f40c8e86274db67fc3f9bbed52615 Mon Sep 17 00:00:00 2001
From: sua yoo <sua@webrecorder.org>
Date: Wed, 21 Aug 2024 15:33:24 -0700
Subject: [PATCH] fix: Hide login link on login page (#2039)

- Removes log in link when on log in page
- Fix e2e test, which wasn't actually logging the test user in before
---
 frontend/src/index.ts        | 26 +++++++++++++-------------
 frontend/tests/login.spec.ts |  2 +-
 2 files changed, 14 insertions(+), 14 deletions(-)

diff --git a/frontend/src/index.ts b/frontend/src/index.ts
index 53d25f82..dbf07c73 100644
--- a/frontend/src/index.ts
+++ b/frontend/src/index.ts
@@ -405,25 +405,25 @@ export class App extends LiteElement {
                     </sl-menu-item>
                   </sl-menu>
                 </sl-dropdown>`
-              : html`
-                  <a href="/log-in"> ${msg("Log In")} </a>
-                  ${this.appState.settings?.registrationEnabled
-                    ? html`
-                        <sl-button
-                          variant="text"
-                          @click="${() => this.navigate("/sign-up")}"
-                        >
-                          ${msg("Sign up")}
-                        </sl-button>
-                      `
-                    : html``}
-                `}
+              : this.renderSignUpLink()}
           </div>
         </nav>
       </div>
     `;
   }
 
+  private renderSignUpLink() {
+    if (!this.appState.settings) return;
+
+    if (this.appState.settings.registrationEnabled) {
+      return html`
+        <sl-button variant="text" @click="${() => this.navigate("/sign-up")}">
+          ${msg("Sign Up")}
+        </sl-button>
+      `;
+    }
+  }
+
   private renderOrgs() {
     const orgs = this.userInfo?.orgs;
     if (!orgs) return;
diff --git a/frontend/tests/login.spec.ts b/frontend/tests/login.spec.ts
index 14e01eff..ad20737d 100644
--- a/frontend/tests/login.spec.ts
+++ b/frontend/tests/login.spec.ts
@@ -20,7 +20,7 @@ test("test", async ({ baseURL }) => {
       );
     }
     await page.fill('input[name="password"]', devPassword);
-    await page.click('a:has-text("Log In")');
+    await page.click('sl-button:has-text("Log In")');
   } finally {
     await browser.close();
   }