From 0e04fd98b140522f37360d5457164d4b25391af2 Mon Sep 17 00:00:00 2001
From: sua yoo <sua@webrecorder.org>
Date: Tue, 11 Feb 2025 16:46:13 -0800
Subject: [PATCH] fix: More accurate archived item details (#2364)

- Moves page count out from under "Size" label in archived item detail
- Renames "Pages Crawled" to "Pages" in archived item leading heading
and detail overview
- Renames "Crawl ID" to "Archived Item ID"

---------

Co-authored-by: Henry Wilkinson <henry@wilkinson.graphics>
---
 .../archived-items/archived-item-list.ts      |  2 +-
 .../archived-item-detail.ts                   | 38 ++++---------------
 frontend/src/pages/org/archived-items.ts      |  2 +-
 3 files changed, 10 insertions(+), 32 deletions(-)

diff --git a/frontend/src/features/archived-items/archived-item-list.ts b/frontend/src/features/archived-items/archived-item-list.ts
index eab15f1b..403e13b7 100644
--- a/frontend/src/features/archived-items/archived-item-list.ts
+++ b/frontend/src/features/archived-items/archived-item-list.ts
@@ -415,7 +415,7 @@ export class ArchivedItemList extends TailwindElement {
       {
         cssCol: "1fr",
         cell: html`<btrix-table-header-cell>
-          ${msg("Pages Crawled")}
+          ${msg("Pages")}
         </btrix-table-header-cell>`,
       },
       {
diff --git a/frontend/src/pages/org/archived-item-detail/archived-item-detail.ts b/frontend/src/pages/org/archived-item-detail/archived-item-detail.ts
index 49a201af..c87cad91 100644
--- a/frontend/src/pages/org/archived-item-detail/archived-item-detail.ts
+++ b/frontend/src/pages/org/archived-item-detail/archived-item-detail.ts
@@ -853,43 +853,21 @@ export class ArchivedItemDetail extends BtrixElement {
                 </btrix-desc-list-item>
               `,
         )}
-
+        <btrix-desc-list-item label=${msg("Pages")}>
+          ${this.item
+            ? html`${this.localize.number(this.item.pageCount || 0)}
+              ${pluralOf("pages", this.item.pageCount || 0)}`
+            : html`<sl-skeleton class="h-[16px] w-24"></sl-skeleton>`}
+        </btrix-desc-list-item>
         <btrix-desc-list-item label=${msg("Size")}>
           ${this.item
             ? html`${this.item.fileSize
-                ? html`${this.localize.bytes(this.item.fileSize || 0, {
-                    unitDisplay: "narrow",
-                  })}${this.item.stats?.done
-                    ? html`<span>,</span
-                        ><span
-                          class="tracking-tighter${this.isActive
-                            ? " text-violet-600"
-                            : ""} font-mono"
-                        >
-                          ${this.localize.number(+this.item.stats.done)}
-                          <span class="text-0-400">/</span>
-                          ${this.localize.number(+this.item.stats.found)}
-                        </span>
-                        <span
-                          >${pluralOf("pages", +this.item.stats.found)}</span
-                        >`
-                    : html`<span>,</span
-                        ><span>
-                          ${this.localize.number(
-                            this.item.pageCount ? +this.item.pageCount : 0,
-                          )}
-                        </span>
-                        <span
-                          >${pluralOf(
-                            "pages",
-                            this.item.pageCount ? +this.item.pageCount : 0,
-                          )}</span
-                        >`}`
+                ? this.localize.bytes(this.item.fileSize || 0)
                 : html`<span class="text-0-400">${msg("Unknown")}</span>`}`
             : html`<sl-skeleton class="h-[16px] w-24"></sl-skeleton>`}
         </btrix-desc-list-item>
         ${this.renderCrawlChannelVersion()}
-        <btrix-desc-list-item label=${msg("Crawl ID")}>
+        <btrix-desc-list-item label=${msg("Archived Item ID")}>
           ${this.item
             ? html`<btrix-copy-field
                 value="${this.item.id}"
diff --git a/frontend/src/pages/org/archived-items.ts b/frontend/src/pages/org/archived-items.ts
index 023d3ddc..2c436da3 100644
--- a/frontend/src/pages/org/archived-items.ts
+++ b/frontend/src/pages/org/archived-items.ts
@@ -619,7 +619,7 @@ export class CrawlsList extends BtrixElement {
               @click=${() => ClipboardController.copyToClipboard(item.id)}
             >
               <sl-icon name="copy" slot="prefix"></sl-icon>
-              ${msg("Copy Crawl ID")}
+              ${msg("Copy Archived Item ID")}
             </sl-menu-item>
           `
         : nothing}