tea/browsertrix
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Hotfix: Crawls page table click targets not applied to the right elements (#1524)

Browse Source 
Fixes #1525

### Changes

- Changes one of the table cell component usages in the crawl list page
to correctly use the `rowClickTarget` prop, rather than setting the
class to `rowClickTarget`.
- Updates the `rowClickTarget` styling to only apply _within_ a
`<btrix-table-cell>`
This commit is contained in:
Emma Segal-Grossman 2024-02-08 17:41:33 -05:00 committed by GitHub
parent 65fec64197
commit 07edf697f0
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
frontend/src/components/ui/table/table.stylesheet.css
View File

@ -5,11 +5,11 @@ btrix-table-cell[rowClickTarget] {
overflow: hidden; overflow: hidden;
} }
.rowClickTarget { btrix-table-cell .rowClickTarget {
max-width: 100%; max-width: 100%;
} }
.rowClickTarget::after { btrix-table-cell .rowClickTarget::after {
content: ""; content: "";
display: block; display: block;
position: absolute; position: absolute;
@ -17,7 +17,7 @@ btrix-table-cell[rowClickTarget] {
grid-column: clickable-start / clickable-end; grid-column: clickable-start / clickable-end;
} }
.rowClickTarget:focus-visible { btrix-table-cell .rowClickTarget:focus-visible {
outline: var(--sl-focus-ring); outline: var(--sl-focus-ring);
outline-offset: -0.25rem; outline-offset: -0.25rem;
border-radius: 0.5rem; border-radius: 0.5rem;

2
frontend/src/features/archived-items/crawl-list.ts
View File

@ -112,7 +112,7 @@ export class CrawlListItem extends TailwindElement {
</btrix-table-cell> </btrix-table-cell>
`; `;
idCell = html` idCell = html`
<btrix-table-cell class="rowClickTarget"> <btrix-table-cell rowClickTarget="a">
${this.href ${this.href
? html`<a href=${this.href} @click=${this.navigate.link}> ? html`<a href=${this.href} @click=${this.navigate.link}>
${label} ${label}